Fwd: Re: Re: HAVE_X11 usage in KIO/core

2014-02-10 Thread David Faure
he user-agent string might have consequences for those that check for it? Regards, Dawit A. On Sat, Feb 8, 2014 at 4:29 AM, David Faure wrote: > Any opinion? > > -- Forwarded Message ------ > > Subject: Re: HAVE_X11 usage in KIO/core > Date: Saturday 08 February 20

Re: HAVE_X11 usage in KIO/core

2014-02-08 Thread Christoph Feck
On Saturday 08 February 2014 00:55:22 Albert Astals Cid wrote: > [about the "X11" string in user agent] > > Sincerely, just drop it. > > We will change from sending > > Mozilla/5.0 (compatible; Konqueror/4.0; Linux; X11; i686; en_US) > KHTML/4.0.1 (like Gecko) > > to > > Mozilla/5.0 (compatible

Re: HAVE_X11 usage in KIO/core

2014-02-07 Thread Albert Astals Cid
El Divendres, 7 de febrer de 2014, a les 15:25:42, Kevin Krammer va escriure: > On Friday, 2014-02-07, 09:51:27, Martin Gräßlin wrote: > > On Friday 07 February 2014 09:38:41 Kevin Krammer wrote: > > > On Friday, 2014-02-07, 08:53:54, Martin Gräßlin wrote: > > > > I'm wondering what to do about it.

Re: HAVE_X11 usage in KIO/core

2014-02-07 Thread Kevin Krammer
On Friday, 2014-02-07, 09:51:27, Martin Gräßlin wrote: > On Friday 07 February 2014 09:38:41 Kevin Krammer wrote: > > On Friday, 2014-02-07, 08:53:54, Martin Gräßlin wrote: > > > I'm wondering what to do about it. The best would be to use > > > QGuiApplication::platformName, but it's a core app. A

Re: HAVE_X11 usage in KIO/core

2014-02-07 Thread Alex Merry
On 07/02/14 11:45, Aleix Pol wrote: > On Fri, Feb 7, 2014 at 9:51 AM, Martin Gräßlin > wrote: > > On Friday 07 February 2014 09:38:41 Kevin Krammer wrote: > > On Friday, 2014-02-07, 08:53:54, Martin Gräßlin wrote: > > > Hi, > > > > > > I found some H

Re: Re: Re: HAVE_X11 usage in KIO/core

2014-02-07 Thread Martin Gräßlin
On Friday 07 February 2014 12:45:47 Aleix Pol wrote: > On Fri, Feb 7, 2014 at 9:51 AM, Martin Gräßlin wrote: > > On Friday 07 February 2014 09:38:41 Kevin Krammer wrote: > > > On Friday, 2014-02-07, 08:53:54, Martin Gräßlin wrote: > > > > Hi, > > > > > > > > I found some HAVE_X11 not defined warn

Re: Re: HAVE_X11 usage in KIO/core

2014-02-07 Thread Aleix Pol
On Fri, Feb 7, 2014 at 9:51 AM, Martin Gräßlin wrote: > On Friday 07 February 2014 09:38:41 Kevin Krammer wrote: > > On Friday, 2014-02-07, 08:53:54, Martin Gräßlin wrote: > > > Hi, > > > > > > I found some HAVE_X11 not defined warnings in KIO and had a look at > them. > > > One of them is in cor

Re: Re: HAVE_X11 usage in KIO/core

2014-02-07 Thread Martin Gräßlin
On Friday 07 February 2014 09:38:41 Kevin Krammer wrote: > On Friday, 2014-02-07, 08:53:54, Martin Gräßlin wrote: > > Hi, > > > > I found some HAVE_X11 not defined warnings in KIO and had a look at them. > > One of them is in core/kprotocolmanager.cpp in the following snippet. > > > > // This is

Re: HAVE_X11 usage in KIO/core

2014-02-07 Thread Kevin Krammer
On Friday, 2014-02-07, 08:53:54, Martin Gräßlin wrote: > Hi, > > I found some HAVE_X11 not defined warnings in KIO and had a look at them. > One of them is in core/kprotocolmanager.cpp in the following snippet. > > // This is not the OS, but the windowing system, e.g. X11 on Unix/Linux. > static

HAVE_X11 usage in KIO/core

2014-02-07 Thread Martin Gräßlin
Hi, I found some HAVE_X11 not defined warnings in KIO and had a look at them. One of them is in core/kprotocolmanager.cpp in the following snippet. // This is not the OS, but the windowing system, e.g. X11 on Unix/Linux. static QString platform() { #if HAVE_X11 return QL1S("X11"); #elif defi