On Friday 19 July 2013 20:11:32 David Faure wrote:
> On Friday 19 July 2013 17:40:26 wojtask w wrote:
> > Before this task I want to cleanup public headers in tier1, tier2 and
> > stagging.
> > I have a question :)
> > 1. What is preferred or ?
>
> Both work, so it doesn't really matter.
>
> The
Alexander Neundorf wrote:
> What happens if you would hide the dependency from C to A ?
>
> Maybe B at some point does not use A anymore
Binary incompatible change. If it is possible that B can be ported away from
A, then use
target_link_libraries(B LINK_PRIVATE A)
and A will not propagate.
On Friday 19 July 2013, Stephen Kelly wrote:
> Stephen Kelly wrote:
> > Qt5::Core is a public dependency of Qt5::Widgets (as is Qt5::Gui), so
> > there's no need to try to be exhaustive with dependencies which cmake
> > will add anyway. You only need to add 'leaf modules'.
>
> To be more clear. I'
Stephen Kelly wrote:
> Qt5::Core is a public dependency of Qt5::Widgets (as is Qt5::Gui), so
> there's no need to try to be exhaustive with dependencies which cmake will
> add anyway. You only need to add 'leaf modules'.
To be more clear. I'm saying only what CMake requires. Public dependencies
David Faure wrote:
>> 3. We have situation
>>
>> a) framework A (public header use QObject and QWidget)
>> -> LINK_PUBLIC only to Qt5::Widgets? or both Qt5::Core and Qt5::Widgets?
>
> I don't know if deps become part of it. I guess not, but I'm no expert.
> Stephen? Alex?
I say
target_link_lib
On Friday 19 July 2013, David Faure wrote:
> On Friday 19 July 2013 17:40:26 wojtask w wrote:
...
> > 3. We have situation
> >
> > a) framework A (public header use QObject and QWidget)
> > -> LINK_PUBLIC only to Qt5::Widgets? or both Qt5::Core and Qt5::Widgets?
>
> I don't know if deps become pa
On Friday 19 July 2013 17:40:26 wojtask w wrote:
> there is a difference between "kf5/kdewidgets" and "kf5/stagging/kwidgets"
Oh, oops.
> But on the other hand I don't understand what "kdewidgets" is (my fix may
> be wrong).
It's the Qt designer plugin which makes all the kde widgets available i
