already depends indirectly on KNotifications which depends on Phonon.
But maybe one day we'll have a notification framework in Qt, and then KIO
won't depend on Phonon anymore :-)
Let's put KFileAudioPreview in kio-extras. KIO works perfectly well without
it, it's not a mandatory runtime dependency
is that it depends on Phonon.
KIO already depends indirectly on KNotifications which depends on Phonon.
But maybe one day we'll have a notification framework in Qt, and then KIO
won't depend on Phonon anymore :-)
Let's put KFileAudioPreview in kio-extras. KIO works perfectly well without
KFileAudioPreview is currently a framework that just provides a plugin.
This plugin is specifically looked for by the KFileMetaPreview class in KIO.
Perhaps it's too late to change this, but it seems to me that this
plugin should either be in KIO or kio-extras. The reason it isn't in KIO
2014-05-12 18:46 GMT-03:00 Alex Merry alex.me...@kde.org:
Perhaps it's too late to change this, but it seems to me that this
plugin should either be in KIO or kio-extras. The reason it isn't in KIO
is that it depends on Phonon.
KIO already depends indirectly on KNotifications which depends on
On 12/05/14 23:18, Nicolás Alvarez wrote:
2014-05-12 18:46 GMT-03:00 Alex Merry alex.me...@kde.org:
Perhaps it's too late to change this, but it seems to me that this
plugin should either be in KIO or kio-extras. The reason it isn't in KIO
is that it depends on Phonon.
KIO already depends
On Monday 12 May 2014 22:46:08 Alex Merry wrote:
KFileAudioPreview is currently a framework that just provides a plugin.
This plugin is specifically looked for by the KFileMetaPreview class in KIO.
Perhaps it's too late to change this, but it seems to me that this
plugin should either
marked as submitted.
Review request for KDE Frameworks.
Repository: kfileaudiopreview
Description
---
Remove transitive dependencies. QtDBus is also not used.
Diffs
-
CMakeLists.txt 413d38c76d2d439f7cc99ac0b67193873458cde6
Diff: https://git.reviewboard.kde.org/r/115584/diff
/
---
(Updated Feb. 8, 2014, 6:52 p.m.)
Review request for KDE Frameworks.
Repository: kfileaudiopreview
Description
---
Remove transitive dependencies. QtDBus is also not used.
Diffs
-
CMakeLists.txt
.)
Review request for KDE Frameworks.
Repository: kfileaudiopreview
Description
---
Remove transitive dependencies. QtDBus is also not used.
Diffs
-
CMakeLists.txt 413d38c76d2d439f7cc99ac0b67193873458cde6
Diff: https://git.reviewboard.kde.org/r/115584/diff
request for KDE Frameworks.
Repository: kdelibs
Description
---
Split kfileaudiopreview out from kmediaplayer
Diffs
-
staging/kfileaudiopreview/CMakeLists.txt PRE-CREATION
staging/CMakeLists.txt 3ca6fbbb119c904ae2ef4682b424d7d68c1fddde
staging
discarded.
Review request for kde-workspace and KDE Frameworks.
Repository: kdelibs
Description
---
Remove kfileaudiopreview, as per discussion on IRC at last frameworks meeting.
I will add it to kde-workspace at the same time I push this.
Diffs
-
staging/kmediaplayer
---
Split kfileaudiopreview out from kmediaplayer
Diffs
-
staging/kfileaudiopreview/CMakeLists.txt PRE-CREATION
staging/CMakeLists.txt 3ca6fbbb119c904ae2ef4682b424d7d68c1fddde
staging/kfileaudiopreview/README PRE-CREATION
staging/kmediaplayer/CMakeLists.txt
request for KDE Frameworks.
Repository: kdelibs
Description
---
One last thing needed before I move this to kde-workspace:
Make KFileAudioPreview use its own config group
Previously, it was using KFileDialog Settings, and this string was
obtained from an internal KIO
catalogue kfileaudiopreview4 to kfileaudiopreview
Diffs
-
staging/kmediaplayer/src/kfileaudiopreview/Messages.sh 71c7067
staging/kmediaplayer/src/kfileaudiopreview/kfileaudiopreview.cpp 04efb24
staging/kmediaplayer/src/kfileaudiopreview/mediacontrols_p.h bb36ab1
Diff: http
---
Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview
Diffs
-
staging/kmediaplayer/src/kfileaudiopreview/Messages.sh
71c7067f3431c1d6d7e920285f1e7382d4218d2d
staging/kmediaplayer/src/kfileaudiopreview/kfileaudiopreview.cpp
04efb249caca5639e3531b092681ce7fba0e8b05
/
---
(Updated Nov. 15, 2013, 12:22 p.m.)
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview
Diffs
-
staging/kmediaplayer/src/kfileaudiopreview/Messages.sh
.
Repository: kdelibs
Description
---
Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview
Diffs
-
staging/kmediaplayer/src/kfileaudiopreview/Messages.sh
71c7067f3431c1d6d7e920285f1e7382d4218d2d
staging/kmediaplayer/src/kfileaudiopreview
/
---
(Updated Nov. 15, 2013, 12:22 p.m.)
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview
Diffs
-
staging/kmediaplayer/src/kfileaudiopreview/Messages.sh
to kfileaudiopreview
Diffs
-
staging/kmediaplayer/src/kfileaudiopreview/Messages.sh
71c7067f3431c1d6d7e920285f1e7382d4218d2d
staging/kmediaplayer/src/kfileaudiopreview/kfileaudiopreview.cpp
04efb249caca5639e3531b092681ce7fba0e8b05
staging/kmediaplayer/src/kfileaudiopreview
, 2013, 1:22 p.m.)
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview
Diffs
-
staging/kmediaplayer/src/kfileaudiopreview/Messages.sh
.
Changes
---
Change number to 5 instead of removing it.
Repository: kdelibs
Description
---
Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview
Diffs (updated)
-
staging/kmediaplayer/src/kfileaudiopreview/Messages.sh 71c7067
staging/kmediaplayer/src
21 matches
Mail list logo
