Re: KHolidays as Framework (redux)

On Tuesday, 23 January 2018 18:36:10 CET Dominik Haumann wrote: > Another question: there are holiday files in the git repo. Are these files > compiled in as resource or loaded via filesystem? > > If these files are not added as resource, this probably breaks on Windows > and OSX. Good point,

Re: KHolidays as Framework (redux)

Another question: there are holiday files in the git repo. Are these files compiled in as resource or loaded via filesystem? If these files are not added as resource, this probably breaks on Windows and OSX. Best regards Dominik Am 20.01.2018 17:37 schrieb "Dominik Haumann"

Re: KHolidays as Framework (redux)

Am 20.01.2018 17:22 schrieb "Volker Krause" : Thanks, should be fixed now. Certainly better, although code examples and the like still would make a significant difference ;) Cheers Dominik On Saturday, 20 January 2018 15:17:53 CET Dominik Haumann wrote: > Hi, > > CC: only

Re: KHolidays as Framework (redux)

Thanks, should be fixed now. On Saturday, 20 January 2018 15:17:53 CET Dominik Haumann wrote: > Hi, > > CC: only kdepim, kde-frameworks-devel > > I have some general comments about the API documentation. Looking at > https://api.kde.org/stable/kdepimlibs-apidocs/kholidays/html/classes.html >

Re: KHolidays as Framework (redux)

Hi, CC: only kdepim, kde-frameworks-devel I have some general comments about the API documentation. Looking at https://api.kde.org/stable/kdepimlibs-apidocs/kholidays/html/classes.html the list mostly (only?) contains classes that are internal. Looking at

Re: KHolidays as Framework (redux)

On Sunday, 14 January 2018 12:55:30 CET David Faure wrote: > On dimanche 14 janvier 2018 10:20:38 CET Volker Krause wrote: > > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote: > > > On Friday 01 January 2016 18:24:17 David Faure wrote: > > > > On Thursday 24 December 2015 12:28:13

Re: KHolidays as Framework (redux)

I'm wrong. the changes are BC since I'm just moving static functions around. Moving KHolidays anytime you want is fine with me. On Sunday, January 14, 2018 2:02:48 PM EST Volker Krause wrote: > On Sunday, 14 January 2018 16:50:08 CET Sandro Knauß wrote: > > @Volker: Is there a need to rush

Re: KHolidays as Framework (redux)

On Sunday, 14 January 2018 16:50:08 CET Sandro Knauß wrote: > @Volker: Is there a need to rush releasing KHolidays it under frameworks? this request is pending since more than 24 month, not exactly my definition of rushing things ;-) We should do the move reasonably early before the next

Re: KHolidays as Framework (redux)

Hey, @Volker: Is there a need to rush releasing KHolidays it under frameworks? As far I see it, the include mechanism do not change find_package do not need to change and also the target_libraries do not need to changed also the API is fixed so far -> no changes in kdepim needed. The only

Re: KHolidays as Framework (redux)

I don't object to making KHolidays a framework. I kinda object to the short timeline. I wanted to finish up some BIC cleaning. No API changes planned at this time. I'll try to hurry. On Sunday, January 14, 2018 4:20:38 AM EST Volker Krause wrote: > On Tuesday, 6 September 2016 12:03:15 CET

Re: KHolidays as Framework (redux)

On dimanche 14 janvier 2018 10:20:38 CET Volker Krause wrote: > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote: > > On Friday 01 January 2016 18:24:17 David Faure wrote: > > > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > > > Hi, > > > > > > > > It's xmas holidays, so

Re: KHolidays as Framework (redux)

On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote: > On Friday 01 January 2016 18:24:17 David Faure wrote: > > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > > Hi, > > > > > > It's xmas holidays, so it must be time to poke a stick at KHolidays > > > again > > > for

Re: KHolidays as Framework (redux)

On Friday 01 January 2016 18:24:17 David Faure wrote: > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > Hi, > > > > It's xmas holidays, so it must be time to poke a stick at KHolidays again > > for inclusion as a Framework. As far as I am aware there are no > > outstanding > > porting

Re: KHolidays as Framework (redux)

On Thursday 24 December 2015 12:28:13 John Layt wrote: > Hi, > > It's xmas holidays, so it must be time to poke a stick at KHolidays again > for inclusion as a Framework. As far as I am aware there are no outstanding > porting issues with KHolidays and it is ready for review to be included as > a

Re: KHolidays as Framework (redux)

On Thu, Dec 24, 2015 at 1:28 PM, John Layt wrote: > Hi, > > It's xmas holidays, so it must be time to poke a stick at KHolidays again > for inclusion as a Framework. As far as I am aware there are no outstanding > porting issues with KHolidays and it is ready for review to be

KHolidays as Framework (redux)

Hi, It's xmas holidays, so it must be time to poke a stick at KHolidays again for inclusion as a Framework. As far as I am aware there are no outstanding porting issues with KHolidays and it is ready for review to be included as a Tier 1 Framework in the next possible release. What's the next