Re: Review Request 113677: Fix standalone build of KUnitConversion

2013-11-06 Thread Commit Hook
/ --- (Updated Nov. 6, 2013, 1:32 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Specify the different dependencies so it builds. Diffs - tier3/kunitconversion/CMakeLists.txt

Re: Review Request 113677: Fix standalone build of KUnitConversion

2013-11-06 Thread Aleix Pol Gonzalez
marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Specify the different dependencies so it builds. Diffs - tier3/kunitconversion/CMakeLists.txt 6895079 Diff: http://git.reviewboard.kde.org/r/113677/diff/ Testing --- Builds, installs

Re: Review Request 113684: Make KunitConversion build standalone

2013-11-06 Thread Alex Merry
: http://git.reviewboard.kde.org/r/113684/ --- (Updated Nov. 6, 2013, 3:10 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Make KUnitConversion build standalone. Based on review

Re: Review Request 113684: Make KunitConversion build standalone

2013-11-06 Thread Maarten De Meyer
. Changes --- Only add kunitconversion to superbuild. Drop other changes. Repository: kdelibs Description --- Make KUnitConversion build standalone. Based on review #113646 Diffs (updated) - superbuild/CMakeLists.txt e965cc8 Diff: http://git.reviewboard.kde.org/r/113684/diff

Re: Review Request 113684: Make KunitConversion build standalone

2013-11-06 Thread Alex Merry
request for KDE Frameworks. Repository: kdelibs Description --- Make KUnitConversion build standalone. Based on review #113646 Diffs - superbuild/CMakeLists.txt e965cc8 Diff: http://git.reviewboard.kde.org/r/113684/diff/ Testing --- Framework

Re: Review Request 113684: Make KunitConversion build standalone

2013-11-06 Thread Maarten De Meyer
marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Make KUnitConversion build standalone. Based on review #113646 Diffs - superbuild/CMakeLists.txt e965cc8 Diff: http://git.reviewboard.kde.org/r/113684/diff/ Testing --- Framework

Re: Review Request 113684: Make KunitConversion build standalone

2013-11-06 Thread Commit Hook
/ --- (Updated Nov. 6, 2013, 3:38 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Make KUnitConversion build standalone. Based on review #113646 Diffs - superbuild

Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Aleix Pol Gonzalez
it to find Qt specifically, nothing else. Diffs - staging/CMakeLists.txt ae2cbf8 staging/kunitconversion/CMakeLists.txt 1346a00 staging/kunitconversion/KUnitConversionConfig.cmake.in staging/kunitconversion/autotests/CMakeLists.txt staging/kunitconversion/autotests/categorytest.h

Re: Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112536/#review39417 --- Before you move kunitconversion, please add the necessary

Re: Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Aleix Pol Gonzalez
staging/kunitconversion/CMakeLists.txt 1346a00 staging/kunitconversion/KUnitConversionConfig.cmake.in 73a5db3 staging/kunitconversion/autotests/CMakeLists.txt staging/kunitconversion/autotests/categorytest.h staging/kunitconversion/autotests/categorytest.cpp staging/kunitconversion

Re: Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Stephen Kelly
/ --- (Updated Sept. 5, 2013, 3:17 p.m.) Review request for KDE Frameworks. Description --- I had to tell it to find Qt specifically, nothing else. Diffs - staging/CMakeLists.txt ae2cbf8 staging/kunitconversion

Re: Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Aleix Pol Gonzalez
. Changes --- Use find_dependency() Description --- I had to tell it to find Qt specifically, nothing else. Diffs (updated) - staging/CMakeLists.txt ae2cbf8 staging/kdoctools/KDocToolsMacros.cmake b1a3457 staging/kunitconversion/CMakeLists.txt 1346a00 staging

Re: Review Request 112536: Move KUnitConversion to tier2

2013-09-05 Thread Commit Hook
/kunitconversion/CMakeLists.txt 1346a00 staging/kunitconversion/KUnitConversionConfig.cmake.in 73a5db3 staging/kunitconversion/autotests/CMakeLists.txt staging/kunitconversion/autotests/categorytest.h staging/kunitconversion/autotests/categorytest.cpp staging/kunitconversion/autotests

Re: Review Request 112331: Splitting KUnitConversion

2013-09-02 Thread Commit Hook
marked as submitted. Review request for KDE Frameworks. Description --- Iterates over KUnitConversion, still not final: - Stops using KDE_PLATFORM_FEATURE_BINARY_COMPATIBLE_FEATURE_REDUCTION - Makes dependencies fixed: - Removes runtime dependency on kioclient and links to Qt5::Network

Re: Review Request 112331: Splitting KUnitConversion

2013-09-02 Thread Commit Hook
/ --- (Updated Aug. 31, 2013, 4:12 p.m.) Review request for KDE Frameworks. Description --- Iterates over KUnitConversion, still not final: - Stops using KDE_PLATFORM_FEATURE_BINARY_COMPATIBLE_FEATURE_REDUCTION - Makes

Re: Review Request 112331: Splitting KUnitConversion

2013-08-31 Thread David Faure
Frameworks. Description --- Iterates over KUnitConversion, still not final: - Stops using KDE_PLATFORM_FEATURE_BINARY_COMPATIBLE_FEATURE_REDUCTION - Makes dependencies fixed: - Removes runtime dependency on kioclient and links to Qt5::Network instead (adding a dependency

Re: Review Request 112331: Splitting KUnitConversion

2013-08-31 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112331/#review38987 --- staging/kunitconversion/src/kunitconversion/CMakeLists.txt

Re: Review Request 112331: Splitting KUnitConversion

2013-08-31 Thread Aleix Pol Gonzalez
On Aug. 31, 2013, 7:20 a.m., Chusslove Illich wrote: staging/kunitconversion/src/kunitconversion/CMakeLists.txt, line 10 http://git.reviewboard.kde.org/r/112331/diff/1/?file=185481#file185481line10 Also the translation domain is configured in config-kunitconversion.h

Re: Review Request 112331: Splitting KUnitConversion

2013-08-31 Thread Aleix Pol Gonzalez
/ --- (Updated Aug. 28, 2013, 4:17 p.m.) Review request for KDE Frameworks. Description --- Iterates over KUnitConversion, still not final: - Stops using KDE_PLATFORM_FEATURE_BINARY_COMPATIBLE_FEATURE_REDUCTION - Makes dependencies fixed: - Removes runtime

Re: Review Request 112331: Splitting KUnitConversion

2013-08-31 Thread Aleix Pol Gonzalez
. Changes --- - Drops Solid dependency in favor of QNetworkSession - Fixes translation by defining TRANSLATION_DOMAIN Description --- Iterates over KUnitConversion, still not final: - Stops using KDE_PLATFORM_FEATURE_BINARY_COMPATIBLE_FEATURE_REDUCTION - Makes dependencies fixed

Re: Review Request 112331: Splitting KUnitConversion

2013-08-31 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112331/#review39040 --- staging/kunitconversion/src/kunitconversion/CMakeLists.txt

<    1   2   3   4