Re: Patch: Move kprotocolmanager to kiocore.

2013-02-12 Thread David Faure
On Monday 11 February 2013 21:59:44 Jignesh Kakadiya wrote: > Hi David, > > It moves kprotocolmanager from kio/kio to kiocore. Builds successfully. > Please review it. Great, please commit. Thanks! -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Framew

Re: Patch: Move kprotocolmanager to kiocore.

2013-02-12 Thread David Faure
On Tuesday 12 February 2013 10:37:56 Jignesh Kakadiya wrote: > Hi David, > > Here is the first patch which removes QGuiAppliction from kprotocolmanager. > Please review it. Thanks, looks good, please commit. Just remove the "symbian" lines, it's not supported by Qt5 anymore. -- David Faure, fa.

Re: Patch: Move kprotocolmanager to kiocore.

2013-02-11 Thread Jignesh Kakadiya
Hi David, Here is the first patch which removes QGuiAppliction from kprotocolmanager. Please review it. Thanks, Jignesh On Mon, Feb 11, 2013 at 10:45 PM, David Faure wrote: > On Monday 11 February 2013 21:59:44 Jignesh Kakadiya wrote: > > Hi David, > > > > It moves kprotocolmanager from kio/k

Re: Patch: Move kprotocolmanager to kiocore.

2013-02-11 Thread David Faure
On Monday 11 February 2013 21:59:44 Jignesh Kakadiya wrote: > Hi David, > > It moves kprotocolmanager from kio/kio to kiocore. Builds successfully. > Please review it. You should make two commits: one which moves the code, and one which makes changes to the code (like the QGuiApplication depende