Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-10-09 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review41449 --- Ship it! Ship It! - Kevin Ottens On Oct. 4, 2013, 5:26

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-10-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review41463 --- This review has been submitted with commit

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-10-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/ --- (Updated Oct. 9, 2013, 6:07 p.m.) Status -- This change has been

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/ --- (Updated Oct. 4, 2013, 5:26 p.m.) Review request for KDE Frameworks,

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-10-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review41190 --- People porting code won't find the new header name. This needs

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-09-30 Thread Mark Gaiser
On Sept. 30, 2013, 11:23 a.m., Aleix Pol Gonzalez wrote: ping? As before, i'm ok with it, but am not going to give another ship it :) That really is up to someone with in deep knowledge about kde4support to see if it makes sense where you placed it. - Mark

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-09-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review40632 --- Probably needs some porting notes in KDE5PORTING to point to

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-09-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/ --- (Updated Sept. 24, 2013, 6:08 p.m.) Review request for KDE Frameworks,

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-09-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/ --- (Updated Sept. 23, 2013, 1:45 p.m.) Review request for KDE Frameworks,

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-09-18 Thread Aleix Pol Gonzalez
On Sept. 18, 2013, 5:23 p.m., Mark Gaiser wrote: Posting the same here as i just said in your other review request. (I didn't see this one) Idea: restore naturalCompare as it was and add a collatorNaturalCompare that is taking the QCollator route. That way it's easily testable as

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-09-18 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review40289 --- Posting the same here as i just said in your other review