Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-11-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/#review44105 --- This review has been submitted with commit

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-11-19 Thread Aurélien Gâteau
On Nov. 12, 2013, 6:11 p.m., Aleix Pol Gonzalez wrote: CMakeLists.txt, line 18 http://git.reviewboard.kde.org/r/113506/diff/5/?file=211419#file211419line18 I don't think we want that, superbuild shouldn't be used after the splitting but the kde build script. We will need it

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-11-19 Thread Ben Cooksley
On Nov. 12, 2013, 5:11 p.m., Aleix Pol Gonzalez wrote: CMakeLists.txt, line 18 http://git.reviewboard.kde.org/r/113506/diff/5/?file=211419#file211419line18 I don't think we want that, superbuild shouldn't be used after the splitting but the kde build script. We will need it

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-11-13 Thread Aurélien Gâteau
On Nov. 12, 2013, 6:11 p.m., Aleix Pol Gonzalez wrote: CMakeLists.txt, line 18 http://git.reviewboard.kde.org/r/113506/diff/5/?file=211419#file211419line18 I don't think we want that, superbuild shouldn't be used after the splitting but the kde build script. We will need it

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-11-13 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/ --- (Updated Nov. 13, 2013, 2:07 p.m.) Review request for Build System, KDE

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-11-13 Thread Aleix Pol Gonzalez
On Nov. 12, 2013, 5:11 p.m., Aleix Pol Gonzalez wrote: CMakeLists.txt, line 18 http://git.reviewboard.kde.org/r/113506/diff/5/?file=211419#file211419line18 I don't think we want that, superbuild shouldn't be used after the splitting but the kde build script. We will need it

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-11-13 Thread Aurélien Gâteau
On Nov. 12, 2013, 6:11 p.m., Aleix Pol Gonzalez wrote: CMakeLists.txt, line 18 http://git.reviewboard.kde.org/r/113506/diff/5/?file=211419#file211419line18 I don't think we want that, superbuild shouldn't be used after the splitting but the kde build script. We will need it

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-11-13 Thread Aleix Pol Gonzalez
On Nov. 12, 2013, 5:11 p.m., Aleix Pol Gonzalez wrote: CMakeLists.txt, line 18 http://git.reviewboard.kde.org/r/113506/diff/5/?file=211419#file211419line18 I don't think we want that, superbuild shouldn't be used after the splitting but the kde build script. We will need it

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-11-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/#review43533 --- CMakeLists.txt

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-11-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/#review43353 --- Please someone with more cmake-fu than myself look at it. It's

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-11-07 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/ --- (Updated Nov. 7, 2013, 3:42 p.m.) Review request for KDE Frameworks,

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-11-04 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/ --- (Updated Nov. 4, 2013, 4:41 p.m.) Review request for KDE Frameworks,

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-10-31 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/ --- (Updated Oct. 31, 2013, 6:50 p.m.) Review request for KDE Frameworks and

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-10-31 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/ --- (Updated Oct. 31, 2013, 7:28 p.m.) Review request for KDE Frameworks and

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-10-31 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/ --- (Updated Oct. 31, 2013, 10:37 p.m.) Review request for KDE Frameworks,