Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-18 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118538/ --- (Updated June 18, 2014, 9:09 a.m.) Status -- This change has been

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118538/#review60277 --- Marco, any chance for a second run of review on that patch?

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-17 Thread Marco Martin
On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: Marco, any chance for a second run of review on that patch? i still not like this patch.. - Marco --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-17 Thread Kevin Ottens
On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: Marco, any chance for a second run of review on that patch? Marco Martin wrote: i still not like this patch.. Should be dropped then? Or it can get somewhere? Feel free to drop it if you consider it a dead end. I prefer that to open

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-17 Thread Marco Martin
On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: Marco, any chance for a second run of review on that patch? Marco Martin wrote: i still not like this patch.. Kevin Ottens wrote: Should be dropped then? Or it can get somewhere? Feel free to drop it if you consider it a

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-17 Thread Kevin Ottens
On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: Marco, any chance for a second run of review on that patch? Marco Martin wrote: i still not like this patch.. Kevin Ottens wrote: Should be dropped then? Or it can get somewhere? Feel free to drop it if you consider it a

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-05 Thread Marco Martin
On June 4, 2014, 7:30 p.m., Marco Martin wrote: what is a valid use case where qml needs to know where the dialog actually is?(not hypothetical please) doing the animation on the proper direction can be tracked completely internally also, plasmoids should never ever do a screen

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118538/#review59234 --- what is a valid use case where qml needs to know where the

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-04 Thread David Edmundson
On June 4, 2014, 7:30 p.m., Marco Martin wrote: what is a valid use case where qml needs to know where the dialog actually is?(not hypothetical please) doing the animation on the proper direction can be tracked completely internally also, plasmoids should never ever do a screen

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-04 Thread Marco Martin
On June 4, 2014, 7:30 p.m., Marco Martin wrote: what is a valid use case where qml needs to know where the dialog actually is?(not hypothetical please) doing the animation on the proper direction can be tracked completely internally also, plasmoids should never ever do a screen

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-04 Thread David Edmundson
On June 4, 2014, 7:30 p.m., Marco Martin wrote: what is a valid use case where qml needs to know where the dialog actually is?(not hypothetical please) doing the animation on the proper direction can be tracked completely internally also, plasmoids should never ever do a screen

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118538/ --- (Updated June 4, 2014, 10:43 p.m.) Review request for KDE Frameworks and