---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119270/#review62294
---
autotests/coronatest.cpp
On July 14, 2014, 1:40 p.m., David Edmundson wrote:
autotests/coronatest.cpp, lines 99-100
https://git.reviewboard.kde.org/r/119270/diff/1/?file=290064#file290064line99
This will wipe the tester's settings, no?
yep, that's the intention, other tests do that as well:
On July 14, 2014, 1:40 p.m., David Edmundson wrote:
autotests/coronatest.cpp, line 70
https://git.reviewboard.kde.org/r/119270/diff/1/?file=290064#file290064line70
Why?
I thought the overriding the plugin loader was so we don't need real
plugins.
whithout any sycoca
On July 14, 2014, 1:40 p.m., David Edmundson wrote:
autotests/coronatest.cpp, line 81
https://git.reviewboard.kde.org/r/119270/diff/1/?file=290064#file290064line81
why is this commented out?
copy and paste, i guess both using it a or not is fine, since it's waiting for
the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119270/
---
(Updated July 14, 2014, 5:22 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119270/#review62312
---
Ship it!
autotests/coronatest.cpp
On July 14, 2014, 5:26 p.m., David Edmundson wrote:
autotests/coronatest.cpp, line 95
https://git.reviewboard.kde.org/r/119270/diff/2/?file=290134#file290134line95
it might make sense to make all of this in init()/cleanup() rather than
initTestCase()
that way each test gets
On July 14, 2014, 5:26 p.m., David Edmundson wrote:
autotests/coronatest.cpp, line 95
https://git.reviewboard.kde.org/r/119270/diff/2/?file=290134#file290134line95
it might make sense to make all of this in init()/cleanup() rather than
initTestCase()
that way each test gets
On July 14, 2014, 5:26 p.m., David Edmundson wrote:
autotests/coronatest.cpp, line 95
https://git.reviewboard.kde.org/r/119270/diff/2/?file=290134#file290134line95
it might make sense to make all of this in init()/cleanup() rather than
initTestCase()
that way each test gets
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119270/
---
(Updated July 14, 2014, 6:57 p.m.)
Status
--
This change has been
10 matches
Mail list logo