Re: Review Request 120388: Do not sync if wallet file does not exist

2015-01-10 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/ --- (Updated Jan. 10, 2015, 5:12 p.m.) Status -- This change has been

Re: Review Request 120388: Do not sync if wallet file does not exist

2014-12-29 Thread Arjun AK
On Dec. 29, 2014, 3:58 a.m., David Faure wrote: low-level review: no need to create a QFile, use QFile::exists(path) higher-level review: ensuring that a file exists before calling KSaveFile, which *creates* the file, sounds weird. I mean, isn't this exactly what will happen the

Re: Review Request 120388: Do not sync if wallet file does not exist

2014-12-29 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/ --- (Updated Dec. 29, 2014, 6:47 p.m.) Review request for KDE Frameworks,

Re: Review Request 120388: Do not sync if wallet file does not exist

2014-12-29 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/#review72750 --- Ship it! Looks goot to me. - Valentin Rusu On Dec. 29,

Re: Review Request 120388: Do not sync if wallet file does not exist

2014-12-10 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/#review71740 --- Ping. - Arjun AK On Sept. 27, 2014, 5:29 p.m., Arjun AK

Re: Review Request 120388: Do not sync if wallet file does not exist

2014-12-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/#review71775 --- +1 Makes sense to me, still I'd like somebody more

Re: Review Request 120388: Do not sync if wallet file does not exist

2014-12-10 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/ --- (Updated Dec. 11, 2014, 2:16 a.m.) Review request for KDE Frameworks,

Re: Review Request 120388: Do not sync if wallet file does not exist

2014-09-27 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/#review67522 --- src/runtime/kwalletd/backend/kwalletbackend.cc