Re: Review Request 123477: Add public dependency on NetworkManager

2015-04-23 Thread Aleix Pol Gonzalez
On April 23, 2015, 3:35 p.m., Jan Grulich wrote: And yes, this is required as long as NetworkManager headers are included by NetworkManagerQt headers. Jan Grulich wrote: I just found out that installing FindNetworkManager.cmake into CMake modules is not enough, because it still

Re: Review Request 123477: Add public dependency on NetworkManager

2015-04-23 Thread Lamarque Souza
On April 23, 2015, 1:35 p.m., Jan Grulich wrote: And yes, this is required as long as NetworkManager headers are included by NetworkManagerQt headers. Jan Grulich wrote: I just found out that installing FindNetworkManager.cmake into CMake modules is not enough, because it still

Re: Review Request 123477: Add public dependency on NetworkManager

2015-04-23 Thread Aleix Pol Gonzalez
On April 23, 2015, 3:35 p.m., Jan Grulich wrote: And yes, this is required as long as NetworkManager headers are included by NetworkManagerQt headers. Jan Grulich wrote: I just found out that installing FindNetworkManager.cmake into CMake modules is not enough, because it still

Re: Review Request 123477: Add public dependency on NetworkManager

2015-04-23 Thread Jan Grulich
On Dub. 23, 2015, 1:35 odp., Jan Grulich wrote: And yes, this is required as long as NetworkManager headers are included by NetworkManagerQt headers. Jan Grulich wrote: I just found out that installing FindNetworkManager.cmake into CMake modules is not enough, because it still

Re: Review Request 123477: Add public dependency on NetworkManager

2015-04-23 Thread Jan Grulich
On Dub. 23, 2015, 1:35 odp., Aleix Pol Gonzalez wrote: KF5NetworkManagerQtConfig.cmake.in, line 4 https://git.reviewboard.kde.org/r/123477/diff/1/?file=362685#file362685line4 nitpick. weird 1 space indentation. Already spotted. On Dub. 23, 2015, 1:35 odp., Jan Grulich wrote: