---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123508/#review79773
---
Ship it!
Ship It!
- David Faure
On May 1, 2015, 9:55
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123508/
---
(Updated May 2, 2015, 9:04 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123508/#review79764
---
The conditional comes from
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123508/#review79754
---
It looks ok to.
+1
Consider it a ship it if noone replies in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123508/
---
(Updated May 2, 2015, 12:55 a.m.)
Review request for KDE Frameworks and
On May 1, 2015, 9:24 p.m., David Faure wrote:
The conditional comes from 50a2283112225e2db4673e41d12411e8664865fa in
kdelibs.git where qMetaTypeIdKShortcut was ported to
qMetaTypeIdQListQKeySequence . However that porting looks wrong indeed,
KShortcut was UserType in QVariant while,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123508/
---
(Updated April 28, 2015, 8:43 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123508/#review79611
---
Could you make a testcase for this?
- Mark Gaiser
On apr
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123508/
---
(Updated April 27, 2015, 6:01 p.m.)
Review request for KDE Frameworks.
