Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

2015-05-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123857/ --- (Updated May 28, 2015, 10:20 a.m.) Status -- This change has been

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

2015-05-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123857/ --- (Updated May 27, 2015, 10:40 a.m.) Review request for KDE Frameworks.

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

2015-05-26 Thread Martin Gräßlin
On May 25, 2015, 8:09 p.m., Eike Hein wrote: Preserving the owner of an existing file is a good idea, but won't help if there isn't one yet ...? David Edmundson wrote: I put in the other two fixes too, the next app would wipe that file and rebuild the DB. Eike Hein wrote:

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

2015-05-25 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123857/#review80819 --- Preserving the owner of an existing file is a good idea, but

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

2015-05-25 Thread David Edmundson
On May 25, 2015, 6:09 p.m., Eike Hein wrote: Preserving the owner of an existing file is a good idea, but won't help if there isn't one yet ...? I put in the other two fixes too, the next app would wipe that file and rebuild the DB. - David

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

2015-05-25 Thread Eike Hein
On May 25, 2015, 6:09 p.m., Eike Hein wrote: Preserving the owner of an existing file is a good idea, but won't help if there isn't one yet ...? David Edmundson wrote: I put in the other two fixes too, the next app would wipe that file and rebuild the DB. I guess I'm not

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

2015-05-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123857/ --- (Updated May 21, 2015, 11:36 a.m.) Review request for KDE Frameworks.

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

2015-05-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123857/#review80649 --- src/kbuildsycoca/kbuildsycoca.cpp (lines 392 - 395)

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

2015-05-20 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123857/#review80650 --- src/services/kservicegroupfactory.cpp (line 37)

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

2015-05-20 Thread David Edmundson
On May 20, 2015, 10:37 a.m., Luigi Toscano wrote: One thing is discouraging running applications as root, another thing is blocking them completely: what will it happen with this patch when the application is run as root, simply no cache and slower application? Isn't it possible to

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

2015-05-20 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123857/#review80654 --- One thing is discouraging running applications as root,

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

2015-05-20 Thread David Edmundson
On May 20, 2015, 10:37 a.m., Luigi Toscano wrote: One thing is discouraging running applications as root, another thing is blocking them completely: what will it happen with this patch when the application is run as root, simply no cache and slower application? Isn't it possible to

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

2015-05-20 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123857/ --- (Updated May 20, 2015, 6:33 p.m.) Review request for KDE Frameworks.

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

2015-05-20 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123857/#review80677 --- src/kbuildsycoca/kbuildsycoca.cpp (line 426)