Re: Review Request 127215: simplify code, reduce pointer dereferences

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127215/ --- (Updated March 2, 2016, 12:03 p.m.) Status -- This change has been

Re: Review Request 127215: simplify code, reduce pointer dereferences

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127215/#review93056 --- Ship it! Well, the Qt bug isn't invalid, there's a bug if

Re: Review Request 127215: simplify code, reduce pointer dereferences

> On Feb. 29, 2016, 4:12 a.m., Aleix Pol Gonzalez wrote: > > src/sycoca/ksycocadict.cpp, line 322 > > > > > > Maybe it's better to leave the * there, as it makes it more clear that > > it's an output argument.

Re: Review Request 127215: simplify code, reduce pointer dereferences

> On Feb. 29, 2016, 8:14 a.m., David Faure wrote: > > src/sycoca/kbuildmimetypefactory.cpp, line 65 > > > > > > Can you keep the order of the operands? I find > > if (var == constant) > > more readable

Re: Review Request 127215: simplify code, reduce pointer dereferences

> On Feb. 29, 2016, 12:31 p.m., Kai Uwe Broulik wrote: > > src/sycoca/kbuildsycoca.cpp, line 143 > > > > > > QVector maybe? > > Nick Shaforostoff wrote: > doesn't make a difference from performance

Re: Review Request 127215: simplify code, reduce pointer dereferences

> On Feb. 29, 2016, 8:14 a.m., David Faure wrote: > > About the unittest failure, I'm available by email to debug that, tests > > shouldn't fail. > > (first thing to check will be: did a > > ~/.qttest/share/applications/faketextapplication.desktop get created?) > > Nick Shaforostoff wrote: >

Re: Review Request 127215: simplify code, reduce pointer dereferences

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127215/#review92966 --- so, any objections for submitting the patch? - Nick

Re: Review Request 127215: simplify code, reduce pointer dereferences

> On Feb. 29, 2016, 12:31 p.m., Kai Uwe Broulik wrote: > > src/sycoca/kbuildservicefactory.cpp, line 167 > > > > > > We can't use range-for in Frameworks, right? in this case i benefit from Q_FOREACH taking a

Re: Review Request 127215: simplify code, reduce pointer dereferences

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127215/#review92899 --- src/sycoca/kbuildservicefactory.cpp (line 162)

Re: Review Request 127215: simplify code, reduce pointer dereferences

> On Feb. 29, 2016, 4:12 a.m., Aleix Pol Gonzalez wrote: > > src/sycoca/kbuildsycoca.cpp, line 246 > > > > > > foreach like you did above? for loops with simple body i prefer direct iterators to a copy-taking

Re: Review Request 127215: simplify code, reduce pointer dereferences

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127215/ --- (Updated Feb. 29, 2016, 12:27 p.m.) Review request for KDE Frameworks.

Re: Review Request 127215: simplify code, reduce pointer dereferences

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127215/#review92884 --- About the unittest failure, I'm available by email to debug

Re: Review Request 127215: simplify code, reduce pointer dereferences

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127215/#review92874 --- src/sycoca/kbuildsycoca.cpp (line 236)