Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127253/ --- (Updated April 11, 2016, 9:26 vorm.) Status -- This change has been

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-09 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127253/#review94450 --- Ship it! Ship It! - John Layt On April 7, 2016, 10:53

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-09 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127253/#review94443 --- - John Layt On April 7, 2016, 10:53 p.m., Kai Uwe Broulik

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127253/#review94405 --- Ship it! Ship It! - David Edmundson On April 7, 2016,

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127253/ --- (Updated April 7, 2016, 9:53 nachm.) Review request for KDE Frameworks,

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-07 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127253/#review94365 --- src/unit.h (line 158)

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-07 Thread Kai Uwe Broulik
> On April 7, 2016, 9:55 vorm., John Layt wrote: > > src/unit.h, line 158 > > > > > > This can be added to the end of the Currency group and still be BIC, > > that's why each group is hard-coded to start at a

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-07 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127253/#review94364 --- One correction to the enum. src/unit.h (line 158)

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127253/#review94362 --- Ping - Kai Uwe Broulik On März 2, 2016, 1:17 vorm., Kai