Re: Review Request 127345: Make it possible for an applet to offer a test object

> On April 15, 2016, 6:45 p.m., LUIS GUSTAVO BARRETO wrote: > > src/plasma/corona.cpp, line 179 > > > > > > If you don't call importLayout() the startupCompleted signal never gets > > emitted causing a slow

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review94644 --- src/plasma/corona.cpp (line 179)

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/ --- (Updated March 16, 2016, 11:40 a.m.) Status -- This change has been

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/ --- (Updated March 16, 2016, 11:40 a.m.) Status -- This change has been

Re: Review Request 127345: Make it possible for an applet to offer a test object

> On March 12, 2016, 8:26 p.m., Marco Martin wrote: > > src/plasmaquick/appletquickitem.h, line 31 > > > > > > appletquickitem.h is now installed as a public header, <> include > > should be fixed somehow Eh,

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review93455 --- src/plasmaquick/appletquickitem.h (line 31)

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/ --- (Updated March 12, 2016, 4 p.m.) Review request for KDE Frameworks and

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review93447 --- Ship it! Ship It! - Sebastian Kügler On March 12,

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/ --- (Updated March 12, 2016, 2:13 p.m.) Review request for KDE Frameworks

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review93444 --- Ship it! for me is a ship it, modulo just calling it just

Re: Review Request 127345: Make it possible for an applet to offer a test object

> On March 12, 2016, 10:26 a.m., Sebastian Kügler wrote: > > src/plasma/private/packages.cpp, line 46 > > > > > > I'd just go for test.qml or perhaps even autotest.qml test.qml would be good if the abstract name

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review93442 --- Fix it, then Ship it! Like my other review: if we want

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/ --- (Updated March 12, 2016, 1:29 a.m.) Review request for KDE Frameworks

Re: Review Request 127345: Make it possible for an applet to offer a test object

> On March 11, 2016, 11:14 p.m., Marco Martin wrote: > > src/plasmaquick/appletquickitem.cpp, line 648 > > > > > > who will be using this? from the shell? Yes, see my patch in plasma-workspace. - Aleix

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review93422 --- src/plasmaquick/appletquickitem.h (line 130)

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review93419 --- I have a rough idea how you want it to work, but to really