Re: Review Request 129057: RFC: Make sense out of Plasma plugin metadata loading

2016-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129057/ --- (Updated Oct. 4, 2016, 9:58 p.m.) Status -- This change has been

Re: Review Request 129057: RFC: Make sense out of Plasma plugin metadata loading

2016-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129057/#review99765 --- Ship it! Ship It! - David Edmundson On Sept. 28, 2016,

Re: Review Request 129057: RFC: Make sense out of Plasma plugin metadata loading

2016-10-04 Thread Aleix Pol Gonzalez
> On Sept. 28, 2016, 3:56 p.m., David Edmundson wrote: > > +1 > > > > though I'd suggest to wait till the start of the next frameworks cycle > > before merging. bump. - Aleix --- This is an automatically generated e-mail. To reply,

Re: Review Request 129057: RFC: Make sense out of Plasma plugin metadata loading

2016-09-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129057/#review99629 --- +1 though I'd suggest to wait till the start of the next

Re: Review Request 129057: RFC: Make sense out of Plasma plugin metadata loading

2016-09-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129057/ --- (Updated Sept. 28, 2016, 3:41 p.m.) Review request for KDE Frameworks

Re: Review Request 129057: RFC: Make sense out of Plasma plugin metadata loading

2016-09-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129057/ --- (Updated Sept. 28, 2016, 3:31 p.m.) Review request for KDE Frameworks

Re: Review Request 129057: RFC: Make sense out of Plasma plugin metadata loading

2016-09-28 Thread Aleix Pol Gonzalez
> On Sept. 28, 2016, 11:10 a.m., Marco Martin wrote: > > src/plasma/applet.cpp, line 92 > > > > > > don't we have already a kpluginmetadata, built in the private ctor? I guess? I'm trying not to change the logic

Re: Review Request 129057: RFC: Make sense out of Plasma plugin metadata loading

2016-09-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129057/#review99615 --- src/plasma/applet.h (line 274)

Re: Review Request 129057: RFC: Make sense out of Plasma plugin metadata loading

2016-09-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129057/#review99608 --- still not ready, but big +1 as it was one of those old todo