---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109667/#review35067
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109667/#review34978
---
Ship it!
Couple of nitpicks otherwise looks good.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109667/
---
(Updated June 22, 2013, 9:31 a.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109667/#review34870
---
i didn't check whether every virtual override is correct, but
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109667/
---
(Updated June 22, 2013, 3:04 p.m.)
Review request for KDE Frameworks and
On March 27, 2013, 7:27 a.m., Oswald Buddenhagen wrote:
tier2/kconfig/autotests/kconfigtest.cpp, line 1238
http://git.reviewboard.kde.org/r/109667/diff/3/?file=122333#file122333line1238
this actually has a good chance of failing on windows. you may need to
restore the write
On March 27, 2013, 7:27 a.m., Oswald Buddenhagen wrote:
tier2/kconfig/autotests/kconfigtest.cpp, line 1238
http://git.reviewboard.kde.org/r/109667/diff/3/?file=122333#file122333line1238
this actually has a good chance of failing on windows. you may need to
restore the write
On March 23, 2013, 9:56 p.m., Oswald Buddenhagen wrote:
tier2/kconfig/src/core/kconfig.cpp, line 440
http://git.reviewboard.kde.org/r/109667/diff/2/?file=121088#file121088line440
well, it appears to fit the pre-existing logic. any particular reason
why you are not sure?
What
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109667/
---
Review request for KDE Frameworks and Oswald Buddenhagen.
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109667/
---
(Updated March 23, 2013, 3:47 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109667/#review29769
---
KDE5PORTING.html
11 matches
Mail list logo