Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-06-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109667/#review35067 --- This review has been submitted with commit

Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-06-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109667/#review34978 --- Ship it! Couple of nitpicks otherwise looks good.

Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-06-22 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109667/ --- (Updated June 22, 2013, 9:31 a.m.) Review request for KDE Frameworks and

Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-06-22 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109667/#review34870 --- i didn't check whether every virtual override is correct, but

Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-06-22 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109667/ --- (Updated June 22, 2013, 3:04 p.m.) Review request for KDE Frameworks and

Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-05-06 Thread Kevin Ottens
On March 27, 2013, 7:27 a.m., Oswald Buddenhagen wrote: tier2/kconfig/autotests/kconfigtest.cpp, line 1238 http://git.reviewboard.kde.org/r/109667/diff/3/?file=122333#file122333line1238 this actually has a good chance of failing on windows. you may need to restore the write

Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-05-06 Thread Albert Astals Cid
On March 27, 2013, 7:27 a.m., Oswald Buddenhagen wrote: tier2/kconfig/autotests/kconfigtest.cpp, line 1238 http://git.reviewboard.kde.org/r/109667/diff/3/?file=122333#file122333line1238 this actually has a good chance of failing on windows. you may need to restore the write

Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-03-26 Thread Albert Astals Cid
On March 23, 2013, 9:56 p.m., Oswald Buddenhagen wrote: tier2/kconfig/src/core/kconfig.cpp, line 440 http://git.reviewboard.kde.org/r/109667/diff/2/?file=121088#file121088line440 well, it appears to fit the pre-existing logic. any particular reason why you are not sure? What

Review Request 109667: Make some KConfig classes return a bool when saving

2013-03-23 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109667/ --- Review request for KDE Frameworks and Oswald Buddenhagen. Description

Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-03-23 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109667/ --- (Updated March 23, 2013, 3:47 p.m.) Review request for KDE Frameworks and

Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-03-23 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109667/#review29769 --- KDE5PORTING.html