On June 3, 2013, 10:18 a.m., David Faure wrote:
kdeui/dialogs/kconfigdialogmanager.cpp, line 146
http://git.reviewboard.kde.org/r/110418/diff/2/?file=146814#file146814line146
OK, first step is a unittest. Can you confirm that your commit breaks
this test?
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110418/#review34080
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110418/#review33350
---
Apar from the KConfigDialogManager issue below, it looks good.
On May 29, 2013, 11:50 a.m., David Faure wrote:
Apar from the KConfigDialogManager issue below, it looks good. However,
please wait until next week to commit it, to give people time to update
their qt5.git build, since you use new API from there
(QSpinBox::setDisplayIntegerBase). I
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110418/
---
(Updated May 28, 2013, 7:44 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110418/
---
(Updated May 28, 2013, 7:45 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110418/
---
Review request for KDE Frameworks and Kevin Ottens.
Description
---
