Re: Review Request 112772: Create an ecm_mark_as_autotest macro

2013-10-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112772/ --- (Updated Oct. 3, 2013, 1:53 p.m.) Status -- This change has been

Re: Review Request 112772: Create an ecm_mark_as_autotest macro

2013-09-18 Thread Alexander Neundorf
On Sept. 17, 2013, 6:26 p.m., Alexander Neundorf wrote: The macro does more than the name implies, additionally to marking it as test it also actually adds the test. So I'd prefer a different name. Having said that, the CMakeLists.txt in the various tests/ subdirs in KDE

Review Request 112772: Create an ecm_mark_as_autotest macro

2013-09-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112772/ --- Review request for Build System and KDE Frameworks. Description ---

Re: Review Request 112772: Create an ecm_mark_as_autotest macro

2013-09-17 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112772/#review40240 --- The macro does more than the name implies, additionally to

Re: Review Request 112772: Create an ecm_mark_as_autotest macro

2013-09-17 Thread Alexander Richardson
On Sept. 17, 2013, 8:26 p.m., Alexander Neundorf wrote: The macro does more than the name implies, additionally to marking it as test it also actually adds the test. So I'd prefer a different name. Having said that, the CMakeLists.txt in the various tests/ subdirs in KDE

Re: Review Request 112772: Create an ecm_mark_as_autotest macro

2013-09-17 Thread Aleix Pol Gonzalez
On Sept. 17, 2013, 6:26 p.m., Alexander Neundorf wrote: The macro does more than the name implies, additionally to marking it as test it also actually adds the test. So I'd prefer a different name. Having said that, the CMakeLists.txt in the various tests/ subdirs in KDE