Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

2013-09-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112816/#review40754 --- This review has been submitted with commit

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

2013-09-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112816/ --- (Updated Sept. 25, 2013, 11:56 a.m.) Status -- This change has been

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

2013-09-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112816/ --- (Updated Sept. 24, 2013, 2:19 p.m.) Review request for KDE Frameworks and

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

2013-09-24 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112816/#review40692 --- tier1/kguiaddons/src/lib/colors/kcolorutils.cpp

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

2013-09-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112816/#review40694 --- Probably we'll need an extra patch on top of this one so that

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

2013-09-24 Thread Sune Vuorela
On Sept. 24, 2013, 2:23 p.m., Sune Vuorela wrote: tier1/kguiaddons/src/lib/colors/kcolorutils.cpp, line 42 http://git.reviewboard.kde.org/r/112816/diff/1/?file=190519#file190519line42 My initial reaction is that it could return a bool wether or not things went okay, given there