Re: Review Request 112907: Move KEmoticons framework to tier3

2013-09-24 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112907/#review40646 --- Please split this into multiple patches. The move should be

Re: Review Request 112907: Move KEmoticons framework to tier3

2013-09-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112907/#review40650 --- staging/kemoticons/src/providers/adium/CMakeLists.txt

Re: Review Request 112907: Move KEmoticons framework to tier3

2013-09-24 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112907/ --- (Updated Sept. 24, 2013, 8:44 p.m.) Status -- This change has been

Re: Review Request 112907: Move KEmoticons framework to tier3

2013-09-23 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112907/ --- (Updated Sept. 23, 2013, 5:41 p.m.) Review request for KDE Frameworks.

Re: Review Request 112907: Move KEmoticons framework to tier3

2013-09-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112907/#review40598 --- Can you provide a patch with --find-copies-harder? It makes

Re: Review Request 112907: Move KEmoticons framework to tier3

2013-09-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112907/#review40599 --- Can you provide a patch with --find-copies-harder? It makes

Re: Review Request 112907: Move KEmoticons framework to tier3

2013-09-23 Thread David Gil Oliva
On Sept. 23, 2013, 6:22 p.m., Aleix Pol Gonzalez wrote: Can you provide a patch with --find-copies-harder? It makes it much easier to read such patches where there are moves and changes. Also, why did you change from Qt5::Xml to Qt5Xml? Also, why did you change from Qt5::Xml to

Review Request 112907: Move KEmoticons framework to tier3

2013-09-23 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112907/ --- Review request for KDE Frameworks. Changes --- Use

Review Request 112907: Move KEmoticons framework to tier3

2013-09-23 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112907/ --- Review request for KDE Frameworks. Description --- Move KEmoticons