Re: Review Request 113378: Trivial warning fixes

2013-10-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113378/#review42343 --- This review has been submitted with commit

Re: Review Request 113378: Trivial warning fixes

2013-10-22 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113378/#review42160 --- interfaces/kimproxy/library/kimproxy.cpp

Re: Review Request 113378: Trivial warning fixes

2013-10-22 Thread Alex Merry
On Oct. 22, 2013, 1:39 p.m., Aurélien Gâteau wrote: interfaces/kimproxy/library/kimproxy.cpp, line 578 http://git.reviewboard.kde.org/r/113378/diff/1/?file=204289#file204289line578 Not sure it is really useful to keep this line at all I left this commented because there is later

Re: Review Request 113378: Trivial warning fixes

2013-10-22 Thread Alex Merry
On Oct. 22, 2013, 1:39 p.m., Aurélien Gâteau wrote: tier3/xmlgui/autotests/kactioncategorytest.cpp, line 92 http://git.reviewboard.kde.org/r/113378/diff/1/?file=204337#file204337line92 Maybe a better solution here would be to change the Q_ASSERT into QVERIFY or QCOMPARE Alex

Re: Review Request 113378: Trivial warning fixes

2013-10-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113378/ --- (Updated Oct. 22, 2013, 4:01 p.m.) Review request for KDE Frameworks.

Review Request 113378: Trivial warning fixes

2013-10-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113378/ --- Review request for KDE Frameworks. Repository: kdelibs Description