---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113378/#review42343
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113378/#review42160
---
interfaces/kimproxy/library/kimproxy.cpp
On Oct. 22, 2013, 1:39 p.m., Aurélien Gâteau wrote:
interfaces/kimproxy/library/kimproxy.cpp, line 578
http://git.reviewboard.kde.org/r/113378/diff/1/?file=204289#file204289line578
Not sure it is really useful to keep this line at all
I left this commented because there is later
On Oct. 22, 2013, 1:39 p.m., Aurélien Gâteau wrote:
tier3/xmlgui/autotests/kactioncategorytest.cpp, line 92
http://git.reviewboard.kde.org/r/113378/diff/1/?file=204337#file204337line92
Maybe a better solution here would be to change the Q_ASSERT into
QVERIFY or QCOMPARE
Alex
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113378/
---
(Updated Oct. 22, 2013, 4:01 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113378/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description