---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113395/#review42583
---
Ship it!
Looks good to me too. The owner id issue can be
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113395/
---
(Updated Oct. 29, 2013, 12:58 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113395/#review42630
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113395/#review42335
---
Looks good to me (don't know about the ownerId() stuff. Maybe
On Oct. 23, 2013, 1:25 a.m., Andrius da Costa Ribas wrote:
tier1/kconfig/src/core/kconfigini.cpp, line 425
http://git.reviewboard.kde.org/r/113395/diff/1/?file=204894#file204894line425
Files have no owner on Windows. QFileInfo::ownerId() always returns -2
on Windows and so would
On Oct. 23, 2013, 3:25 a.m., Andrius da Costa Ribas wrote:
tier1/kconfig/src/core/kconfigini.cpp, line 425
http://git.reviewboard.kde.org/r/113395/diff/1/?file=204894#file204894line425
Files have no owner on Windows. QFileInfo::ownerId() always returns -2
on Windows and so would
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113395/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113395/#review42192
---
tier1/kconfig/src/core/kconfigini.cpp
On Oct. 23, 2013, 1:25 a.m., Andrius da Costa Ribas wrote:
tier1/kconfig/src/core/kconfigini.cpp, line 425
http://git.reviewboard.kde.org/r/113395/diff/1/?file=204894#file204894line425
Files have no owner on Windows. QFileInfo::ownerId() always returns -2
on Windows and so would