---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113685/
---
(Updated Nov. 18, 2013, 8:44 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113685/#review43872
---
This review has been submitted with commit
On Nov. 15, 2013, 7:42 p.m., Kevin Ottens wrote:
tier3/kconfigwidgets/src/kcolorschememanager.cpp, line 124
http://git.reviewboard.kde.org/r/113685/diff/3/?file=213999#file213999line124
Would make sense to change the lambda so that you'd pass 16 and 24
instead. It feels kinda
On Monday 18 November 2013 Nov 09:17:07 Albert Astals Cid wrote:
So you're saying Boud's and Christoph comments are wrong?
My comment was meant to convey that color palettes have nothing to do with this
patch -- they're a red herring here.
--
Boudewijn Rempt
http://www.valdyas.org,
On Nov. 15, 2013, 8:42 p.m., Kevin Ottens wrote:
tier3/kconfigwidgets/src/kcolorschememanager.cpp, line 124
http://git.reviewboard.kde.org/r/113685/diff/3/?file=213999#file213999line124
Would make sense to change the lambda so that you'd pass 16 and 24
instead. It feels kinda
On Nov. 15, 2013, 8:42 p.m., Kevin Ottens wrote:
tier3/kconfigwidgets/src/kcolorschememanager.cpp, line 124
http://git.reviewboard.kde.org/r/113685/diff/3/?file=213999#file213999line124
Would make sense to change the lambda so that you'd pass 16 and 24
instead. It feels kinda
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113685/#review43755
---
Ship it!
I propose a couple tiny improvements. Do what you
On Nov. 15, 2013, 7:42 p.m., Kevin Ottens wrote:
tier3/kconfigwidgets/src/kcolorschememanager.cpp, line 124
http://git.reviewboard.kde.org/r/113685/diff/3/?file=213999#file213999line124
Would make sense to change the lambda so that you'd pass 16 and 24
instead. It feels kinda
On Nov. 12, 2013, 10:49 p.m., Albert Astals Cid wrote:
About the .colors translations, we have this
./kdeui/colors/kcolordialog.cpp:104:{ 40.colors,
I18N_NOOP2(palette name, Forty Colors) },
./kdeui/colors/kcolordialog.cpp:105:{ Oxygen.colors,
I18N_NOOP2(palette name,
On Nov. 12, 2013, 10:49 p.m., Albert Astals Cid wrote:
About the .colors translations, we have this
./kdeui/colors/kcolordialog.cpp:104:{ 40.colors,
I18N_NOOP2(palette name, Forty Colors) },
./kdeui/colors/kcolordialog.cpp:105:{ Oxygen.colors,
I18N_NOOP2(palette name,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113685/#review43607
---
tier3/kconfigwidgets/src/kcolorschememanager.h
On Nov. 13, 2013, 5:41 p.m., David Faure wrote:
tier3/kconfigwidgets/src/kcolorschememanager.cpp, line 93
http://git.reviewboard.kde.org/r/113685/diff/2/?file=212585#file212585line93
this is still a C++11 initializer list, which isn't in the wiki page of
allowed C++11 constructs
On Nov. 13, 2013, 4:41 p.m., David Faure wrote:
tier3/kconfigwidgets/src/kcolorschememanager.cpp, line 93
http://git.reviewboard.kde.org/r/113685/diff/2/?file=212585#file212585line93
this is still a C++11 initializer list, which isn't in the wiki page of
allowed C++11 constructs
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113685/
---
(Updated Nov. 14, 2013, 6:50 a.m.)
Review request for KDE Frameworks,
On Nov. 10, 2013, 10:54 a.m., David Faure wrote:
tier3/kconfigwidgets/src/kcolorscheme.h, line 596
http://git.reviewboard.kde.org/r/113685/diff/1/?file=210267#file210267line596
Wouldn't Oxygen be translated, normally?
If so, isn't this bad API, giving a translated name
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113685/
---
(Updated Nov. 12, 2013, 9:13 a.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113685/
---
(Updated Nov. 12, 2013, 9:48 a.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113685/#review43557
---
About the .colors translations, we have this
On Nov. 12, 2013, 11:49 p.m., Albert Astals Cid wrote:
About the .colors translations, we have this
./kdeui/colors/kcolordialog.cpp:104:{ 40.colors,
I18N_NOOP2(palette name, Forty Colors) },
./kdeui/colors/kcolordialog.cpp:105:{ Oxygen.colors,
I18N_NOOP2(palette name,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113685/#review43408
---
For me, it looks like it has the functionality I'd need for
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113685/
---
Review request for KDE Frameworks, Gilles Caulier and Boudewijn Rempt.
21 matches
Mail list logo