---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/#review48760
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/
---
(Updated Feb. 2, 2014, 11:06 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/#review48742
---
Ship it!
Ship It!
- Alex Merry
On Feb. 1, 2014, 7:40
On Jan. 30, 2014, 3:49 p.m., David Edmundson wrote:
src/kstartupinfo.cpp, line 1068
https://git.reviewboard.kde.org/r/115251/diff/2/?file=240679#file240679line1068
Does this need a runtime check?
no that should be fine. The Qt method delegates to nativeResourceForScreen in
the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/#review48713
---
src/kstartupinfo.cpp
On Jan. 31, 2014, 9:45 p.m., Alex Merry wrote:
src/kstartupinfo.cpp, lines 458-480
https://git.reviewboard.kde.org/r/115251/diff/2/?file=240679#file240679line458
Surely we shouldn't be using KXMessages if we don't have X11?
(Also applies to the next bunch of methods)
I
On Jan. 31, 2014, 8:45 p.m., Alex Merry wrote:
src/kstartupinfo.cpp, lines 458-480
https://git.reviewboard.kde.org/r/115251/diff/2/?file=240679#file240679line458
Surely we shouldn't be using KXMessages if we don't have X11?
(Also applies to the next bunch of methods)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/
---
(Updated Feb. 1, 2014, 8:40 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/#review48622
---
src/kstartupinfo.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/
---
(Updated Jan. 27, 2014, 8:31 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/
---
Review request for KDE Frameworks.
Repository: kwindowsystem
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/#review48141
---
Ship it!
The rest of the code is fine, +1 from me.
12 matches
Mail list logo