Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

2014-02-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115251/#review48760 --- This review has been submitted with commit

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

2014-02-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115251/ --- (Updated Feb. 2, 2014, 11:06 a.m.) Status -- This change has been

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

2014-02-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115251/#review48742 --- Ship it! Ship It! - Alex Merry On Feb. 1, 2014, 7:40

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

2014-01-31 Thread Martin Gräßlin
On Jan. 30, 2014, 3:49 p.m., David Edmundson wrote: src/kstartupinfo.cpp, line 1068 https://git.reviewboard.kde.org/r/115251/diff/2/?file=240679#file240679line1068 Does this need a runtime check? no that should be fine. The Qt method delegates to nativeResourceForScreen in the

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

2014-01-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115251/#review48713 --- src/kstartupinfo.cpp

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

2014-01-31 Thread Martin Gräßlin
On Jan. 31, 2014, 9:45 p.m., Alex Merry wrote: src/kstartupinfo.cpp, lines 458-480 https://git.reviewboard.kde.org/r/115251/diff/2/?file=240679#file240679line458 Surely we shouldn't be using KXMessages if we don't have X11? (Also applies to the next bunch of methods) I

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

2014-01-31 Thread Alex Merry
On Jan. 31, 2014, 8:45 p.m., Alex Merry wrote: src/kstartupinfo.cpp, lines 458-480 https://git.reviewboard.kde.org/r/115251/diff/2/?file=240679#file240679line458 Surely we shouldn't be using KXMessages if we don't have X11? (Also applies to the next bunch of methods)

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

2014-01-31 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115251/ --- (Updated Feb. 1, 2014, 8:40 a.m.) Review request for KDE Frameworks.

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

2014-01-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115251/#review48622 --- src/kstartupinfo.cpp

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

2014-01-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115251/ --- (Updated Jan. 27, 2014, 8:31 a.m.) Review request for KDE Frameworks.

Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

2014-01-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115251/ --- Review request for KDE Frameworks. Repository: kwindowsystem

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

2014-01-23 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115251/#review48141 --- Ship it! The rest of the code is fine, +1 from me.