Re: Review Request 115345: Fix kimageformats build with MSVC

2014-02-03 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115345/ --- (Updated Feb. 3, 2014, 6:24 p.m.) Status -- This change has been

Re: Review Request 115345: Fix kimageformats build with MSVC

2014-02-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115345/#review48848 --- This review has been submitted with commit

Re: Review Request 115345: Fix kimageformats build with MSVC

2014-02-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115345/#review48849 --- This review has been submitted with commit

Re: Review Request 115345: Fix kimageformats build with MSVC

2014-02-03 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115345/ --- (Updated Feb. 3, 2014, 6:24 p.m.) Status -- This change has been

Re: Review Request 115345: Fix kimageformats build with MSVC

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115345/#review48461 --- Ship it! Hmm, it now appears that PIC was already broken.

Review Request 115345: Fix kimageformats build with MSVC

2014-01-27 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115345/ --- Review request for KDE Frameworks, kdewin and Alex Merry. Repository:

Re: Review Request 115345: Fix kimageformats build with MSVC

2014-01-27 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115345/#review48421 --- src/imageformats/pic_write.cpp

Re: Review Request 115345: Fix kimageformats build with MSVC

2014-01-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115345/#review48422 --- Just ran a quick test, using the imageconverter tool in the

Re: Review Request 115345: Fix kimageformats build with MSVC

2014-01-27 Thread Alex Merry
On Jan. 27, 2014, 10:36 p.m., Alex Merry wrote: Just ran a quick test, using the imageconverter tool in the tests/ directory. I created orig.pcx and orig.pic before applying the patch, with ./imageconverter /some/image.bmp orig.pcx ./imageconverter /some/image.bmp orig.pic and then

Re: Review Request 115345: Fix kimageformats build with MSVC

2014-01-27 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115345/ --- (Updated Jan. 28, 2014, 12:40 a.m.) Review request for KDE Frameworks

Re: Review Request 115345: Fix kimageformats build with MSVC

2014-01-27 Thread Alexander Richardson
On Jan. 27, 2014, 11:36 p.m., Alex Merry wrote: Just ran a quick test, using the imageconverter tool in the tests/ directory. I created orig.pcx and orig.pic before applying the patch, with ./imageconverter /some/image.bmp orig.pcx ./imageconverter /some/image.bmp orig.pic and then