Re: Review Request 115394: Split KCompletionBase from kcompletion.h

2014-01-31 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115394/#review48678 --- Ship it! Had to redo the changes in kcompletion.h because of

Re: Review Request 115394: Split KCompletionBase from kcompletion.h

2014-01-31 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115394/ --- (Updated Jan. 31, 2014, 10:53 p.m.) Status -- This change has been

Re: Review Request 115394: Split KCompletionBase from kcompletion.h

2014-01-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115394/#review48729 --- This review has been submitted with commit

Re: Review Request 115394: Split KCompletionBase from kcompletion.h

2014-01-30 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115394/#review48605 --- Looks good. Minor nitpicks: - I would use `#include

Re: Review Request 115394: Split KCompletionBase from kcompletion.h

2014-01-30 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115394/ --- (Updated Jan. 30, 2014, 10:59 p.m.) Review request for KDE Frameworks.

Review Request 115394: Split KCompletionBase from kcompletion.h

2014-01-29 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115394/ --- Review request for KDE Frameworks. Repository: kcompletion Description