Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

2014-03-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/#review53313 --- This review has been submitted with commit

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

2014-03-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/ --- (Updated March 18, 2014, 12:17 p.m.) Status -- This change has been

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

2014-03-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/#review53190 --- Ship it! Ship It! - Kevin Ottens On March 15, 2014, 3:37

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

2014-03-15 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/ --- (Updated March 15, 2014, 4:37 p.m.) Review request for KDE Frameworks

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

2014-03-12 Thread Kevin Ottens
On March 4, 2014, 8:45 p.m., Kevin Ottens wrote: And I agree with Aurélien, a bug should be filed and Stephen involved in that issue. Stephen Kelly wrote: Please provide a minimal testcase. The feature is unit tested in cmake. If it's broken, it needs to be fixed soon (before the

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

2014-03-12 Thread Stephen Kelly
On March 4, 2014, 8:45 p.m., Kevin Ottens wrote: And I agree with Aurélien, a bug should be filed and Stephen involved in that issue. Stephen Kelly wrote: Please provide a minimal testcase. The feature is unit tested in cmake. If it's broken, it needs to be fixed soon (before the

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

2014-03-10 Thread Alexander Richardson
On March 4, 2014, 9:45 p.m., Kevin Ottens wrote: And I agree with Aurélien, a bug should be filed and Stephen involved in that issue. Stephen Kelly wrote: Please provide a minimal testcase. The feature is unit tested in cmake. If it's broken, it needs to be fixed soon (before the

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

2014-03-05 Thread Stephen Kelly
On March 4, 2014, 8:45 p.m., Kevin Ottens wrote: And I agree with Aurélien, a bug should be filed and Stephen involved in that issue. Please provide a minimal testcase. The feature is unit tested in cmake. If it's broken, it needs to be fixed soon (before the final 3.0 release). -

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

2014-03-05 Thread Stephen Kelly
On March 4, 2014, 8:45 p.m., Kevin Ottens wrote: And I agree with Aurélien, a bug should be filed and Stephen involved in that issue. Stephen Kelly wrote: Please provide a minimal testcase. The feature is unit tested in cmake. If it's broken, it needs to be fixed soon (before the

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

2014-03-04 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/ --- (Updated March 4, 2014, 8:45 p.m.) Review request for KDE Frameworks and

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

2014-03-04 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/#review51946 --- Ship it! And I agree with Aurélien, a bug should be filed

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

2014-02-27 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/#review51043 --- While this fix would certainly work, I think it would be good