Re: Review Request 116087: KCrash: remove usage of strlcpy

2014-03-12 Thread Kevin Ottens
On March 1, 2014, 4:17 p.m., David Faure wrote: Hmm, this might be equivalent, but all it means is that the orig code was wrong. We should not make any memory allocations within the crash handler. So we should instead store the startup id as a const char* somewhere and use

Re: Review Request 116087: KCrash: remove usage of strlcpy

2014-03-12 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116087/ --- (Updated March 12, 2014, 3:26 p.m.) Review request for KDE Frameworks

Re: Review Request 116087: KCrash: remove usage of strlcpy

2014-03-12 Thread David Faure
On March 1, 2014, 4:17 p.m., David Faure wrote: Hmm, this might be equivalent, but all it means is that the orig code was wrong. We should not make any memory allocations within the crash handler. So we should instead store the startup id as a const char* somewhere and use

Re: Review Request 116087: KCrash: remove usage of strlcpy

2014-03-04 Thread Alexander Richardson
On March 1, 2014, 5:17 p.m., David Faure wrote: Hmm, this might be equivalent, but all it means is that the orig code was wrong. We should not make any memory allocations within the crash handler. So we should instead store the startup id as a const char* somewhere and use

Re: Review Request 116087: KCrash: remove usage of strlcpy

2014-03-03 Thread Alex Merry
On March 1, 2014, 4:17 p.m., David Faure wrote: Hmm, this might be equivalent, but all it means is that the orig code was wrong. We should not make any memory allocations within the crash handler. So we should instead store the startup id as a const char* somewhere and use

Re: Review Request 116087: KCrash: remove usage of strlcpy

2014-03-03 Thread Alex Merry
On March 1, 2014, 4:17 p.m., David Faure wrote: Hmm, this might be equivalent, but all it means is that the orig code was wrong. We should not make any memory allocations within the crash handler. So we should instead store the startup id as a const char* somewhere and use

Re: Review Request 116087: KCrash: remove usage of strlcpy

2014-03-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116087/#review51440 --- Hmm, this might be equivalent, but all it means is that the

Re: Review Request 116087: KCrash: remove usage of strlcpy

2014-02-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116087/#review51008 --- Ship it! The QByteArray clearly has the same lifetime as the

Review Request 116087: KCrash: remove usage of strlcpy

2014-02-26 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116087/ --- Review request for KDE Frameworks. Repository: kcrash Description