Re: Review Request 116959: Remove KDE 4 references from kcmutils

2014-03-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/#review53955 --- This review has been submitted with commit

Re: Review Request 116959: Remove KDE 4 references from kcmutils

2014-03-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/ --- (Updated March 24, 2014, 11:44 a.m.) Status -- This change has been

Re: Review Request 116959: Remove KDE 4 references from kcmutils

2014-03-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/#review53953 --- This review has been submitted with commit

Re: Review Request 116959: Remove KDE 4 references from kcmutils

2014-03-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/#review53954 --- This review has been submitted with commit

Re: Review Request 116959: Remove KDE 4 references from kcmutils

2014-03-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/#review53956 --- This review has been submitted with commit

Re: Review Request 116959: Remove KDE 4 references from kcmutils

2014-03-24 Thread Alex Merry
On March 23, 2014, 9:35 p.m., David Faure wrote: src/kcmultidialog.cpp, line 424 https://git.reviewboard.kde.org/r/116959/diff/1/?file=256012#file256012line424 this if() isn't needed, already tested in the parent scope. Oops, worse than that. I'd replaced rootOnlyMessage()

Re: Review Request 116959: Remove KDE 4 references from kcmutils

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/#review53855 --- Ship it! with one fix first src/kcmultidialog.cpp

Review Request 116959: Remove KDE 4 references from kcmutils

2014-03-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/ --- Review request for KDE Frameworks. Repository: kcmutils Description