Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-27 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118289/ --- (Updated May 27, 2014, 1:55 p.m.) Status -- This change has been mar

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118289/#review58568 --- This review has been submitted with commit c9b553aa40612a65e5

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-27 Thread Jens Reuterberg
> On May 27, 2014, 9:56 a.m., Christoph Feck wrote: > > I'll leave the decision which factor to use to the VDG. > > Thomas Pfeiffer wrote: > To get feedback from the VDG, I'd suggest adding alake to the request, > he's our expert on those matters. > > Sebastian Kügler wrote: > I've not

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-27 Thread Sebastian Kügler
> On May 27, 2014, 9:56 a.m., Christoph Feck wrote: > > I'll leave the decision which factor to use to the VDG. > > Thomas Pfeiffer wrote: > To get feedback from the VDG, I'd suggest adding alake to the request, > he's our expert on those matters. I've notified Jens, he's in a more conveni

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-27 Thread Thomas Pfeiffer
> On May 27, 2014, 9:56 a.m., Christoph Feck wrote: > > I'll leave the decision which factor to use to the VDG. To get feedback from the VDG, I'd suggest adding alake to the request, he's our expert on those matters. - Thomas --- This

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-27 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118289/#review58546 --- Ship it! I'll leave the decision which factor to use to the V

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118289/ --- (Updated May 27, 2014, midnight) Review request for KDE Frameworks, KDE U

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118289/ --- (Updated May 26, 2014, 11:59 p.m.) Review request for KDE Frameworks, KDE

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118289/ --- (Updated May 26, 2014, 11:57 p.m.) Review request for KDE Frameworks, KDE

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-26 Thread Sebastian Kügler
> On May 26, 2014, 10:18 a.m., Christoph Feck wrote: > > The original screen shot looks bad, because the bold font looks smaller > > than the normal font. This might be because of wrong hinting settings, or > > because of a bad font design. > > > > Regarding the scaling factor, CSS recommends

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-26 Thread Christoph Feck
> On May 26, 2014, 10:18 a.m., Christoph Feck wrote: > > The original screen shot looks bad, because the bold font looks smaller > > than the normal font. This might be because of wrong hinting settings, or > > because of a bad font design. > > > > Regarding the scaling factor, CSS recommends

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-26 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118289/#review58454 --- The original screen shot looks bad, because the bold font look

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118289/ --- (Updated May 26, 2014, 10 a.m.) Review request for KDE Frameworks, KDE Us

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-26 Thread Sebastian Kügler
> On May 24, 2014, 1:57 a.m., Mark Gaiser wrote: > > src/ktitlewidget.cpp, line 44 > > > > > > Can you at least make this a bit less "magical"? Right now it's just > > "size * 1.3".. Why 1.3? What is the basis be

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118289/ --- (Updated May 26, 2014, 9:58 a.m.) Review request for KDE Frameworks and C

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118289/ --- (Updated May 26, 2014, 1:36 a.m.) Review request for KDE Frameworks, KDE

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-23 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118289/#review58383 --- src/ktitlewidget.cpp

Review Request 118289: Change titlewidget from bold to increased font size

2014-05-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118289/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kwidget