---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119043/#review61923
---
Build is failing now when BUILD_EXAMPLES is turned on.
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119043/
---
(Updated July 7, 2014, 7:28 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119043/#review61766
---
Ship it!
Looks good to me.
- Aleix Pol Gonzalez
On July
On July 1, 2014, 1:43 a.m., Aleix Pol Gonzalez wrote:
core/CMakeLists.txt, line 24
https://git.reviewboard.kde.org/r/119043/diff/4/?file=285778#file285778line24
Maybe we want to set an EXPORT_NAME? This way the user won't need a
variable to link to the library.
It's
On July 1, 2014, 1:43 a.m., Aleix Pol Gonzalez wrote:
core/CMakeLists.txt, line 24
https://git.reviewboard.kde.org/r/119043/diff/4/?file=285778#file285778line24
Maybe we want to set an EXPORT_NAME? This way the user won't need a
variable to link to the library.
It's
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119043/
---
(Updated July 1, 2014, 8:23 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119043/
---
Review request for KDE Frameworks, Polkit Qt, Aleix Pol Gonzalez, and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119043/
---
(Updated June 30, 2014, 10:28 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119043/#review61326
---
agent/CMakeLists.txt
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119043/
---
(Updated June 30, 2014, 10:51 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119043/
---
(Updated June 30, 2014, 11:53 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119043/#review61334
---
CMakeLists.txt
On June 30, 2014, 8:37 p.m., Christophe Giboudeaux wrote:
agent/CMakeLists.txt, line 10
https://git.reviewboard.kde.org/r/119043/diff/2/?file=285757#file285757line10
LINK_PUBLIC
On June 30, 2014, 8:37 p.m., Christophe Giboudeaux wrote:
core/CMakeLists.txt, line 13
On June 30, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote:
CMakeLists.txt, line 6
https://git.reviewboard.kde.org/r/119043/diff/4/?file=285775#file285775line6
Isn't it acceptable to depend on ECM here?
not a wise choice. the master branch allows building both the Qt4 Qt5 variant
On June 30, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote:
PolkitQt-1Config.cmake.in, line 24
https://git.reviewboard.kde.org/r/119043/diff/4/?file=285776#file285776line24
Passing the include dir is not needed anymore, given that those will be
pulled by the targets.
I
15 matches
Mail list logo
