Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119409/ --- (Updated July 23, 2014, 10:31 a.m.) Status -- This change has been m

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119409/ --- (Updated July 23, 2014, 9:18 a.m.) Review request for KDE Frameworks and

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
> On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555 > > > > > > Why can't you just call the method? You're not delaying it > > Marco Martin w

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread David Edmundson
> On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555 > > > > > > Why can't you just call the method? You're not delaying it > > Marco Martin w

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
> On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555 > > > > > > Why can't you just call the method? You're not delaying it > > Marco Martin w

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Aleix Pol Gonzalez
> On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555 > > > > > > Why can't you just call the method? You're not delaying it > > Marco Martin w

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
> On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555 > > > > > > Why can't you just call the method? You're not delaying it > > Marco Martin w

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Aleix Pol Gonzalez
> On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: > > Forgot to say, I think introducing a X-Plasma-Provides is ok. I guess that it will contain the concepts it's fulfilling, right? such as: X-Plasma-Provides=clock > On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: > > src/script

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119409/ --- (Updated July 22, 2014, 4:10 p.m.) Review request for KDE Frameworks and

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
> On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555 > > > > > > Why can't you just call the method? You're not delaying it ah, no, because th

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119409/#review62891 --- src/scriptengines/qml/plasmoid/appletinterface.cpp

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119409/ --- (Updated July 22, 2014, 3:40 p.m.) Review request for KDE Frameworks and

Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119409/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor