Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/#review65111 --- With the port the checkbox no longer scales with dpi. The PM

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-24 Thread David Edmundson
On Aug. 24, 2014, 9:53 a.m., Kai Uwe Broulik wrote: With the port the checkbox no longer scales with dpi. The PM checkbox in battery monitor has become quite small here now. the width/height looks like it has changed, it used to be width: theme.mSize(theme.defaultFont).height +

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-20 Thread Marco Martin
On Aug. 19, 2014, 7:43 p.m., David Edmundson wrote: src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml, line 33 https://git.reviewboard.kde.org/r/119846/diff/1/?file=306474#file306474line33 Good question. I think it is needed to set background to

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/ --- (Updated Aug. 20, 2014, 9:36 a.m.) Review request for KDE Frameworks and

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-20 Thread Marco Martin
On Aug. 19, 2014, 7:43 p.m., David Edmundson wrote: src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml, line 51 https://git.reviewboard.kde.org/r/119846/diff/1/?file=306474#file306474line51 checked isn't a boolean, it's an enum of the checked, partial,

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/ --- (Updated Aug. 20, 2014, 1:05 p.m.) Review request for KDE Frameworks and

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-20 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/#review64922 --- Ship it! Ship It! - David Edmundson On Aug. 20, 2014,

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/ --- (Updated Aug. 20, 2014, 6:51 p.m.) Status -- This change has been

Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/#review64882 ---

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-19 Thread Marco Martin
On Aug. 19, 2014, 7:43 p.m., David Edmundson wrote: src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml, line 51 https://git.reviewboard.kde.org/r/119846/diff/1/?file=306474#file306474line51 checked isn't a boolean, it's an enum of the checked, partial,