Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Martin Klapetek
> On Nov. 3, 2014, 8:59 p.m., Christophe Giboudeaux wrote: > > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the > > facebook resource builds fine without this patch). > > > > KF5PimUtilsTargets.cmake sets this: > > set_target_properties(KF5::PimUtils PROPERTIES > > INTERFA

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120959/ --- (Updated nov. 3, 2014, 11:06 après-midi) Status -- This change has b

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Christophe Giboudeaux
> On nov. 3, 2014, 7:59 après-midi, Christophe Giboudeaux wrote: > > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the > > facebook resource builds fine without this patch). > > > > KF5PimUtilsTargets.cmake sets this: > > set_target_properties(KF5::PimUtils PROPERTIES > > I

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Martin Klapetek
> On Nov. 3, 2014, 8:59 p.m., Christophe Giboudeaux wrote: > > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the > > facebook resource builds fine without this patch). > > > > KF5PimUtilsTargets.cmake sets this: > > set_target_properties(KF5::PimUtils PROPERTIES > > INTERFA

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Christophe Giboudeaux
> On nov. 3, 2014, 7:59 après-midi, Christophe Giboudeaux wrote: > > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the > > facebook resource builds fine without this patch). > > > > KF5PimUtilsTargets.cmake sets this: > > set_target_properties(KF5::PimUtils PROPERTIES > > I

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Martin Klapetek
> On Nov. 3, 2014, 8:59 p.m., Christophe Giboudeaux wrote: > > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the > > facebook resource builds fine without this patch). > > > > KF5PimUtilsTargets.cmake sets this: > > set_target_properties(KF5::PimUtils PROPERTIES > > INTERFA

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Christophe Giboudeaux
> On nov. 3, 2014, 7:59 après-midi, Christophe Giboudeaux wrote: > > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the > > facebook resource builds fine without this patch). > > > > KF5PimUtilsTargets.cmake sets this: > > set_target_properties(KF5::PimUtils PROPERTIES > > I

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Martin Klapetek
> On Nov. 3, 2014, 8:59 p.m., Christophe Giboudeaux wrote: > > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the > > facebook resource builds fine without this patch). > > > > KF5PimUtilsTargets.cmake sets this: > > set_target_properties(KF5::PimUtils PROPERTIES > > INTERFA

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Christophe Giboudeaux
> On nov. 3, 2014, 7:59 après-midi, Christophe Giboudeaux wrote: > > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the > > facebook resource builds fine without this patch). > > > > KF5PimUtilsTargets.cmake sets this: > > set_target_properties(KF5::PimUtils PROPERTIES > > I

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120959/ --- (Updated Nov. 3, 2014, 10:21 p.m.) Review request for KDE Frameworks, KDE

Re: Review Request 120959: [KPimUtils] Don't install headers into $include_dir/KPIMUtils/KPIMUtils

2014-11-03 Thread Martin Klapetek
> On Nov. 3, 2014, 8:59 p.m., Christophe Giboudeaux wrote: > > KPIMUtils/KPIMUtils/SomeHeader is correct. This patch isn't (and the > > facebook resource builds fine without this patch). > > > > KF5PimUtilsTargets.cmake sets this: > > set_target_properties(KF5::PimUtils PROPERTIES > > INTERFA