https://git.reviewboard.kde.org/r/121094/
This change fails to compile on Windows, because the unit test has
ktexttohtml.cpp as a source file *and* it's linking to the kcoreaddons
library which obviously defines the same function. In addition,
ktexttohtml.h in this context is declaring the
2014-12-08 23:37 GMT-03:00 Nicolás Alvarez nicolas.alva...@gmail.com:
https://git.reviewboard.kde.org/r/121094/
This change fails to compile on Windows, because the unit test has
ktexttohtml.cpp as a source file *and* it's linking to the kcoreaddons
library which obviously defines the same
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121094/
---
(Updated Dec. 3, 2014, 2:18 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121094/
---
(Updated Dec. 2, 2014, 5:57 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121094/#review71266
---
Ship it!
Good by me :) Two small notes below, but not commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121094/#review71147
---
src/lib/text/ktexttohtml_p.h
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121094/
---
(Updated Dec. 1, 2014, 7:40 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121094/
---
(Updated Nov. 18, 2014, 2:37 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121094/
---
(Updated Nov. 14, 2014, 1:37 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121094/#review70369
---
autotests/ktexttohtmltest.cpp
On Nov. 11, 2014, 12:22 p.m., Laurent Montel wrote:
src/lib/text/ktexttohtml.cpp, line 380
https://git.reviewboard.kde.org/r/121094/diff/1/?file=327569#file327569line380
same here
There's no semantic difference between x++ and ++x here, I don't see the point
of requesting this
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121094/#review70234
---
src/lib/text/ktexttohtml.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121094/
---
(Updated Nov. 11, 2014, 1:49 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121094/
---
(Updated Nov. 11, 2014, 3:51 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121094/
---
Review request for KDE Frameworks.
Repository: kcoreaddons
Description
15 matches
Mail list logo
