Re: Review Request 121263: Prevent API abuse of calling setters on temporary objects.

2015-02-08 Thread Christoph Cullmann
On Nov. 27, 2014, 7:29 a.m., Christoph Cullmann wrote: I actually would prefer no such hack in the public headers. If that is just to make porting easier, you can use that locally as a patch until the kdevplatform code is cleaned up. Milian Wolff wrote: I still don't get why you

Re: Review Request 121263: Prevent API abuse of calling setters on temporary objects.

2015-02-08 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121263/ --- (Updated Feb. 8, 2015, 2:42 p.m.) Status -- This change has been

Re: Review Request 121263: Prevent API abuse of calling setters on temporary objects.

2014-12-13 Thread Dominik Haumann
On Nov. 27, 2014, 7:29 vorm., Christoph Cullmann wrote: I actually would prefer no such hack in the public headers. If that is just to make porting easier, you can use that locally as a patch until the kdevplatform code is cleaned up. Milian Wolff wrote: I still don't get why you

Re: Review Request 121263: Prevent API abuse of calling setters on temporary objects.

2014-12-08 Thread Milian Wolff
On Nov. 27, 2014, 7:29 a.m., Christoph Cullmann wrote: I actually would prefer no such hack in the public headers. If that is just to make porting easier, you can use that locally as a patch until the kdevplatform code is cleaned up. I still don't get why you think this is a hack, or

Re: Review Request 121263: Prevent API abuse of calling setters on temporary objects.

2014-12-08 Thread Christoph Cullmann
On Nov. 27, 2014, 7:29 a.m., Christoph Cullmann wrote: I actually would prefer no such hack in the public headers. If that is just to make porting easier, you can use that locally as a patch until the kdevplatform code is cleaned up. Milian Wolff wrote: I still don't get why you

Re: Review Request 121263: Prevent API abuse of calling setters on temporary objects.

2014-11-26 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121263/ --- (Updated Nov. 27, 2014, 1:15 a.m.) Review request for KDE Frameworks,

Re: Review Request 121263: Prevent API abuse of calling setters on temporary objects.

2014-11-26 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121263/#review70996 --- I actually would prefer no such hack in the public headers.