Re: Review Request 121972: Make ksycocadicttest work when sycoca does not exist yet.

2015-01-11 Thread Alex Merry
On Jan. 11, 2015, 1:03 a.m., David Faure wrote: Can you explain to me what the patch really changes? AFAICS this is a no-op. The same logic with a different syntax. Alex Merry wrote: Lazy evaluation of || means that if KSycoca::isAvailable() returns false,

Re: Review Request 121972: Make ksycocadicttest work when sycoca does not exist yet.

2015-01-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121972/#review73736 --- Ship it! Oh! I see. OK. - David Faure On Jan. 10, 2015,

Re: Review Request 121972: Make ksycocadicttest work when sycoca does not exist yet.

2015-01-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121972/ --- (Updated Jan. 11, 2015, 4:19 p.m.) Status -- This change has been

Review Request 121972: Make ksycocadicttest work when sycoca does not exist yet.

2015-01-10 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121972/ --- Review request for KDE Frameworks and David Faure. Repository: kservice