Re: Review Request 122204: Mark results as required.

2015-01-25 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122204/ --- (Updated Jan. 25, 2015, 3:53 p.m.) Status -- This change has been

Re: Review Request 122204: Mark results as required.

2015-01-23 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122204/#review74632 --- Ship it! Ship It! - Chusslove Illich On Јан. 22, 2015,

Re: Review Request 122204: Mark results as required.

2015-01-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122204/#review74576 --- Ship it! It if just warns, then sure. I assume there's a

Review Request 122204: Mark results as required.

2015-01-22 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122204/ --- Review request for KDE Frameworks and Chusslove Illich. Repository:

Re: Review Request 122204: Mark results as required.

2015-01-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122204/#review74568 --- +1 This change is not source-compatible though... 8-) or is

Re: Review Request 122204: Mark results as required.

2015-01-22 Thread Aleix Pol Gonzalez
On Jan. 23, 2015, 12:11 a.m., Aleix Pol Gonzalez wrote: +1 This change is not source-compatible though... 8-) or is it? Milian Wolff wrote: It's _meant_ to be source-incompatible. All places where it doesn't compile are doing it wrong™. If you mean abi-incompatible,

Re: Review Request 122204: Mark results as required.

2015-01-22 Thread Milian Wolff
On Jan. 22, 2015, 11:11 p.m., Aleix Pol Gonzalez wrote: +1 This change is not source-compatible though... 8-) or is it? It's _meant_ to be source-incompatible. All places where it doesn't compile are doing it wrong™. If you mean abi-incompatible, then no - I don't think this changes

Re: Review Request 122204: Mark results as required.

2015-01-22 Thread Kevin Funk
On Jan. 22, 2015, 11:11 p.m., Aleix Pol Gonzalez wrote: +1 This change is not source-compatible though... 8-) or is it? Milian Wolff wrote: It's _meant_ to be source-incompatible. All places where it doesn't compile are doing it wrong™. If you mean abi-incompatible,