Re: Review Request 122300: Fix quoteArgs for spaces that are not the regular space

2015-02-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122300/ --- (Updated Feb. 2, 2015, 10:46 p.m.) Status -- This change has been

Re: Review Request 122300: Fix quoteArgs for spaces that are not the regular space

2015-01-29 Thread Albert Astals Cid
On gen. 29, 2015, 7:46 a.m., David Faure wrote: Shouldn't splitArgs be fixed instead? After all a real shell would not split on that character, would it? That is indeed a good question. Bash doesn't seem to need the quotes, but i don't know about other shells, and i figured out adding

Re: Review Request 122300: Fix quoteArgs for spaces that are not the regular space

2015-01-29 Thread David Faure
On Jan. 29, 2015, 7:46 a.m., David Faure wrote: Shouldn't splitArgs be fixed instead? After all a real shell would not split on that character, would it? Albert Astals Cid wrote: That is indeed a good question. Bash doesn't seem to need the quotes, but i don't know about other

Review Request 122300: Fix quoteArgs for spaces that are not the regular space

2015-01-28 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122300/ --- Review request for KDE Frameworks, David Faure and Michael Pyne. Bugs:

Re: Review Request 122300: Fix quoteArgs for spaces that are not the regular space

2015-01-28 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122300/#review74959 --- Ship it! I would prefer to either comment the predicates

Re: Review Request 122300: Fix quoteArgs for spaces that are not the regular space

2015-01-28 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122300/ --- (Updated gen. 28, 2015, 11:24 p.m.) Review request for KDE Frameworks,

Re: Review Request 122300: Fix quoteArgs for spaces that are not the regular space

2015-01-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122300/#review74967 --- Shouldn't splitArgs be fixed instead? After all a real shell