Re: Review Request 122493: Use math.h round rather than C++11 std::lround.

2015-02-09 Thread Marco Martin
On Feb. 9, 2015, 12:59 a.m., Mark Gaiser wrote: -1 You use C-Style casts. Oke, the frameworks coding style doesn't seem to explicitly forbid it (casts are not mentioned), but if i recall correctly we use the Qt style + some of our own which means we should obey the Qt style [1]

Re: Review Request 122493: Use math.h round rather than C++11 std::lround.

2015-02-09 Thread Ivan Čukić
On Feb. 9, 2015, 12:59 a.m., Mark Gaiser wrote: -1 You use C-Style casts. Oke, the frameworks coding style doesn't seem to explicitly forbid it (casts are not mentioned), but if i recall correctly we use the Qt style + some of our own which means we should obey the Qt style [1]

Re: Review Request 122493: Use math.h round rather than C++11 std::lround.

2015-02-09 Thread Kevin Funk
On Feb. 9, 2015, 12:59 a.m., Mark Gaiser wrote: -1 You use C-Style casts. Oke, the frameworks coding style doesn't seem to explicitly forbid it (casts are not mentioned), but if i recall correctly we use the Qt style + some of our own which means we should obey the Qt style [1]

Review Request 122493: Use math.h round rather than C++11 std::lround.

2015-02-08 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122493/ --- Review request for KDE Frameworks and Marco Martin. Repository:

Re: Review Request 122493: Use math.h round rather than C++11 std::lround.

2015-02-08 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122493/#review75648 --- -1 You use C-Style casts. Oke, the frameworks coding style

Re: Review Request 122493: Use math.h round rather than C++11 std::lround.

2015-02-08 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122493/#review75646 --- `qRound`? - Kevin Funk On Feb. 8, 2015, 11:12 p.m., Jeremy