Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

2015-02-17 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/#review76186 --- Ship it! src/knotifyconfigelement.h

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

2015-02-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/#review76184 --- Ship it! i'm not 100% sure on the issue below, apart from

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

2015-02-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/#review75983 --- +1 What's the status of QtSpeech? - Aleix Pol Gonzalez On

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

2015-02-13 Thread Jeremy Whiting
On Feb. 13, 2015, 4:49 a.m., Aleix Pol Gonzalez wrote: +1 What's the status of QtSpeech? I'll blog about it shortly. - Jeremy --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

2015-02-13 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/ --- (Updated Feb. 13, 2015, 12:42 p.m.) Review request for KDE Frameworks

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

2015-02-13 Thread Frederik Gladhorn
On Feb. 13, 2015, 11:49 a.m., Aleix Pol Gonzalez wrote: +1 What's the status of QtSpeech? Jeremy Whiting wrote: I'll blog about it shortly. I think QtSpeech is Qt 5.6 material realistically. It's usable on most platforms but needs cleanup and API review and a couple of features

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

2015-02-13 Thread Frederik Gladhorn
On Feb. 13, 2015, 12:17 p.m., Martin Klapetek wrote: src/knotifyconfigactionswidgetbase.ui, line 141 https://git.reviewboard.kde.org/r/122554/diff/1/?file=348626#file348626line141 Is Jovie still used in QtSpeech? If not, it should be removed from here I tend to agree to TTS or even

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

2015-02-13 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/#review75987 --- As I said in the other review, I believe the user facing

Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

2015-02-12 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/ --- Review request for KDE Frameworks and Frederik Gladhorn. Repository: