Re: Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

2015-03-07 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122621/#review77149 --- Ping - Emmanuel Pescosta On Feb. 18, 2015, 12:14 p.m.,

Re: Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

2015-03-07 Thread Emmanuel Pescosta
On March 7, 2015, 11:05 a.m., David Faure wrote: sftp/kio_sftp.h, line 215 https://git.reviewboard.kde.org/r/122621/diff/1/?file=350140#file350140line215 not really a todo for this particular class then, it wouldn't change ;) Just copied the comment from smb ioslave, but I agree

Re: Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

2015-03-07 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122621/ --- (Updated March 7, 2015, 11:42 a.m.) Status -- This change has been

Re: Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

2015-03-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122621/#review77155 --- Ship it! sftp/kio_sftp.h

Re: Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

2015-02-26 Thread Vishesh Handa
On Feb. 25, 2015, 10:24 a.m., Vishesh Handa wrote: sftp/kio_sftp.cpp, line 247 https://git.reviewboard.kde.org/r/122621/diff/1/?file=350141#file350141line247 The code indentation seems wrong. Emmanuel Pescosta wrote: Just followed the coding style (1 tab - 2 spaces) from

Re: Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

2015-02-25 Thread Emmanuel Pescosta
On Feb. 25, 2015, 11:24 a.m., Vishesh Handa wrote: sftp/kio_sftp.cpp, line 247 https://git.reviewboard.kde.org/r/122621/diff/1/?file=350141#file350141line247 The code indentation seems wrong. Just followed the coding style (1 tab - 2 spaces) from kio_sftp.cpp Should I use the

Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

2015-02-18 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122621/ --- Review request for KDE Frameworks and Andreas Schneider. Repository: