Re: Review Request 122913: Added an event() version that takes no icon and will use a default one

2015-03-13 Thread Albert Vaca Cintora
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122913/ --- (Updated March 14, 2015, 4:58 a.m.) Status -- This change has been

Re: Review Request 122913: Added an event() version that takes no icon and will use a default one

2015-03-13 Thread Albert Vaca Cintora
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122913/ --- (Updated mar. 14, 2015, 5:57 a.m.) Review request for KDE Frameworks and

Re: Review Request 122913: Added an event() version that takes no icon and will use a default one

2015-03-13 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122913/#review77433 --- Ship it! Thanks!! ...+ the QStringLiteral change ;)

Re: Review Request 122913: Added an event() version that takes no icon and will use a default one

2015-03-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122913/#review77350 --- Small nitpick. src/knotification.cpp

Review Request 122913: Added an event() version that takes no icon and will use a default one

2015-03-11 Thread Albert Vaca Cintora
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122913/ --- Review request for KDE Frameworks and Martin Klapetek. Repository:

Re: Review Request 122913: Added an event() version that takes no icon and will use a default one

2015-03-11 Thread Albert Vaca Cintora
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122913/ --- (Updated mar. 12, 2015, 4:37 a.m.) Review request for KDE Frameworks and