Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341/ --- (Updated May 23, 2015, 3:20 p.m.) Status -- This change has been

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341/#review80625 --- Ship it! this looks good to me, esp. considering there is a

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341/#review80631 --- autotests/test_settings.cpp (line 43)

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

On May 19, 2015, 3:12 p.m., Vishesh Handa wrote: autotests/test_settings.cpp, line 43 https://git.reviewboard.kde.org/r/123341/diff/4/?file=362129#file362129line43 Minor thing, which is up to you. In this test you're allocating the `Speller` off the heap and having to

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

On maj 19, 2015, 3:12 e.m., Vishesh Handa wrote: autotests/test_settings.cpp, line 43 https://git.reviewboard.kde.org/r/123341/diff/4/?file=362129#file362129line43 Minor thing, which is up to you. In this test you're allocating the `Speller` off the heap and having to

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341/ --- (Updated April 19, 2015, 7:46 p.m.) Review request for KDE Frameworks

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341/ --- (Updated April 19, 2015, 7:49 p.m.) Review request for KDE Frameworks

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

On avr. 12, 2015, 8:03 matin, Laurent Montel wrote: Perhaps it's time to create an unittest :) We need to be sure that it will save when we change settings no ? Kåre Särs wrote: Any hints on how to test that QSettings::setValue() is called properly (or save()) without

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341/#review78845 --- src/core/settings.cpp (line 77)

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341/#review78846 --- Perhaps it's time to create an unittest :) We need to be sure

Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

On April 12, 2015, 8:03 a.m., Laurent Montel wrote: Perhaps it's time to create an unittest :) We need to be sure that it will save when we change settings no ? Any hints on how to test that QSettings::setValue() is called properly (or save()) without writing/modifying the Sonnet