Re: Review Request 123360: Introduce LoopSound flag

2015-04-15 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123360/ --- (Updated April 15, 2015, 11:21 a.m.) Status -- This change has been

Review Request 123360: Introduce LoopSound flag

2015-04-14 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123360/ --- Review request for KDE Frameworks. Bugs: 346148

Re: Review Request 123360: Introduce LoopSound flag

2015-04-14 Thread Lamarque Souza
On April 14, 2015, 3:50 p.m., Lamarque Souza wrote: src/notifybyaudio.cpp, line 89 https://git.reviewboard.kde.org/r/123360/diff/1/?file=361076#file361076line89 Should not this patch be followed by another patch that set LoopSound flag for Persistant notifications that *really*

Re: Review Request 123360: Introduce LoopSound flag

2015-04-14 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123360/#review78950 --- Ship it! Ship It! - Lamarque Souza On April 14, 2015,

Re: Review Request 123360: Introduce LoopSound flag

2015-04-14 Thread Martin Klapetek
On April 14, 2015, 5:50 p.m., Lamarque Souza wrote: src/notifybyaudio.cpp, line 89 https://git.reviewboard.kde.org/r/123360/diff/1/?file=361076#file361076line89 Should not this patch be followed by another patch that set LoopSound flag for Persistant notifications that *really*