Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-06-05 Thread Sebastian Kügler
On May 7, 2015, 7:24 a.m., Alex Richardson wrote: Seems like this is duplicated in a few places already so I agree we should add it. But won't most users of the API want only a single plugin returned? Maybe also add a function `KPluginMetaData KPluginLoader::findPluginById(const

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-06-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123669/ --- (Updated June 6, 2015, 4:59 a.m.) Status -- This change has been

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-06-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123669/#review81254 --- Ship it! Ship It! - Marco Martin On May 6, 2015, 11:21

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-05-08 Thread Alex Richardson
On May 7, 2015, 8:24 a.m., Alex Richardson wrote: Seems like this is duplicated in a few places already so I agree we should add it. But won't most users of the API want only a single plugin returned? Maybe also add a function `KPluginMetaData KPluginLoader::findPluginById(const

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-05-07 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123669/#review80013 --- Seems like this is duplicated in a few places already so I

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-05-07 Thread Sebastian Kügler
On May 7, 2015, 7:24 a.m., Alex Richardson wrote: Seems like this is duplicated in a few places already so I agree we should add it. But won't most users of the API want only a single plugin returned? Maybe also add a function `KPluginMetaData KPluginLoader::findPluginById(const

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-05-07 Thread Sebastian Kügler
On May 6, 2015, 11:24 p.m., David Edmundson wrote: autotests/kpluginloadertest.cpp, line 357 https://git.reviewboard.kde.org/r/123669/diff/1/?file=367268#file367268line357 not that it really matters, but invalid is spelt wrong. Double the invalidity. it says invalid id,

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-05-07 Thread Sebastian Kügler
On May 7, 2015, 7:24 a.m., Alex Richardson wrote: Seems like this is duplicated in a few places already so I agree we should add it. But won't most users of the API want only a single plugin returned? Maybe also add a function `KPluginMetaData KPluginLoader::findPluginById(const

Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-05-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123669/ --- Review request for KDE Frameworks, Alex Richardson and David Faure.

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-05-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123669/#review80001 --- +1 seems sensible. autotests/kpluginloadertest.cpp (line