Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-24 Thread Aleix Pol Gonzalez
On June 24, 2015, 9:17 p.m., Alex Merry wrote: src/kconfig_compiler/CMakeLists.txt, line 13 https://git.reviewboard.kde.org/r/124104/diff/2/?file=380381#file380381line13 A bit late to the party, sorry, but this would be better as message(WARNING ...). You're right. I'll add it

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/#review81729 --- src/kconfig_compiler/CMakeLists.txt (line 13)

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/ --- (Updated June 21, 2015, 12:16 a.m.) Status -- This change has been

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-17 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/#review81550 --- From a cross-compile POV, this makes sense. I can't comment

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-17 Thread Matthew Dawson
On June 15, 2015, 11:12 p.m., Matthew Dawson wrote: src/kconfig_compiler/CMakeLists.txt, line 16 https://git.reviewboard.kde.org/r/124104/diff/1/?file=380232#file380232line16 Does this mean a cross-compiled KConfig won't be built right for development on the target? If this

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-17 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/#review81545 --- Ship it! Ship It! - Harald Sitter On June 18, 2015, 1:19

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/ --- (Updated June 18, 2015, 3:19 a.m.) Review request for Build System, KDE

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-15 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/#review81501 --- +1 on the idea from me. I don't know CMake well, so I'd

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-15 Thread Aleix Pol Gonzalez
On June 16, 2015, 5:12 a.m., Matthew Dawson wrote: src/kconfig_compiler/CMakeLists.txt, line 16 https://git.reviewboard.kde.org/r/124104/diff/1/?file=380232#file380232line16 Does this mean a cross-compiled KConfig won't be built right for development on the target? If this

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/#review81500 --- +1 - David Edmundson On June 15, 2015, 5:59 p.m., Aleix

Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/ --- Review request for Build System, KDE Frameworks, Matthew Dawson, and